- Notifications
You must be signed in to change notification settings - Fork11.2k
fix: Conditional fetch cache#24816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedOct 31, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts"><violation number="1" location="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts:69">Rule violated: **Avoid Logging Sensitive Information**Logging selectedCalendars dumps the full IntegrationCalendar objects, which include optional email fields. This exposes PII in logs and violates our "Avoid Logging Sensitive Information" rule. Please strip or sanitize sensitive fields in this log (and apply the same fix to the similar log in getAvailabilityWithTimeZones).</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…pper tests- Add checkIfUserHasFeatureNonHierarchical to features.repository mock to fix failing GoogleCalendar tests- Add comprehensive unit tests for CalendarCacheWrapper covering: - Calendars with sync only (cache-only path) - Calendars without sync only (original calendar path) - Mixed calendars (both cache and original) - Timezone handling with UTC defaults - Edge cases (empty arrays, undefined methods, null ids)- Use proper types instead of 'as any' to satisfy lint rulesCo-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 2 files
- Replace logging full selectedCalendars objects with only calendar IDs and count- Prevents exposure of email fields and other sensitive information in logs- Addresses AI code reviewer feedbackCo-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts"><violation number="1" location="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts:72">Rule violated: **Avoid Logging Sensitive Information**Avoid logging calendar IDs; they frequently contain user email addresses or other sensitive identifiers, violating our "Avoid Logging Sensitive Information" rule. Please remove or redact the logged IDs in both availability methods.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/app-store/_utils/getCalendar.ts"><violation number="1" location="packages/app-store/_utils/getCalendar.ts:53">Switching to the non-hierarchical feature check stops users from inheriting CALENDAR_SUBSCRIPTION_CACHE_FEATURE from parent teams, so eligible accounts now fail the flag check and caching gets disabled.</violation></file>React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 5 files
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No issues found across 1 file
emrysal left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Happy with this, straightforward code, perhaps some duplication on with/without sync but not an issue. Left a minor nit.
Uh oh!
There was an error while loading.Please reload this page.
github-actionsbot commentedNov 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
E2E results are ready! |
cc1efe1 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
Fetches calendar cache only when it's available avoiding loading cache for not synced calendars.