Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Conditional fetch cache#24816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
volnei merged 15 commits intomainfromfix/conditional-fetch-cache
Nov 19, 2025
Merged

fix: Conditional fetch cache#24816

volnei merged 15 commits intomainfromfix/conditional-fetch-cache
Nov 19, 2025

Conversation

@volnei
Copy link
Contributor

@volneivolnei commentedOct 31, 2025
edited
Loading

What does this PR do?

Fetches calendar cache only when it's available avoiding loading cache for not synced calendars.

@keithwillcodekeithwillcode added corearea: core, team members only foundation labelsOct 31, 2025
@vercel
Copy link

vercelbot commentedOct 31, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments
ProjectDeploymentPreviewCommentsUpdated (UTC)
calIgnoredIgnoredNov 18, 2025 10:56pm
cal-euIgnoredIgnoredNov 18, 2025 10:56pm

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 3 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts"><violation number="1" location="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts:69">Rule violated: **Avoid Logging Sensitive Information**Logging selectedCalendars dumps the full IntegrationCalendar objects, which include optional email fields. This exposes PII in logs and violates our &quot;Avoid Logging Sensitive Information&quot; rule. Please strip or sanitize sensitive fields in this log (and apply the same fix to the similar log in getAvailabilityWithTimeZones).</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

…pper tests- Add checkIfUserHasFeatureNonHierarchical to features.repository mock to fix failing GoogleCalendar tests- Add comprehensive unit tests for CalendarCacheWrapper covering:  - Calendars with sync only (cache-only path)  - Calendars without sync only (original calendar path)  - Mixed calendars (both cache and original)  - Timezone handling with UTC defaults  - Edge cases (empty arrays, undefined methods, null ids)- Use proper types instead of 'as any' to satisfy lint rulesCo-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 2 files

- Replace logging full selectedCalendars objects with only calendar IDs and count- Prevents exposure of email fields and other sensitive information in logs- Addresses AI code reviewer feedbackCo-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 5 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts"><violation number="1" location="packages/features/calendar-subscription/lib/cache/CalendarCacheWrapper.ts:72">Rule violated: **Avoid Logging Sensitive Information**Avoid logging calendar IDs; they frequently contain user email addresses or other sensitive identifiers, violating our &quot;Avoid Logging Sensitive Information&quot; rule. Please remove or redact the logged IDs in both availability methods.</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 issue found across 5 files

Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.<file name="packages/app-store/_utils/getCalendar.ts"><violation number="1" location="packages/app-store/_utils/getCalendar.ts:53">Switching to the non-hierarchical feature check stops users from inheriting CALENDAR_SUBSCRIPTION_CACHE_FEATURE from parent teams, so eligible accounts now fail the flag check and caching gets disabled.</violation></file>

React with 👍 or 👎 to teach cubic. Mention@cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 5 files

Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issues found across 1 file

emrysal
emrysal previously approved these changesNov 18, 2025
Copy link
Contributor

@emrysalemrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Happy with this, straightforward code, perhaps some duplication on with/without sync but not an issue. Left a minor nit.

volnei reacted with heart emoji
emrysal
emrysal previously approved these changesNov 18, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedNov 18, 2025
edited
Loading

E2E results are ready!

@volneivolnei merged commitcc1efe1 intomainNov 19, 2025
60 of 63 checks passed
@volneivolnei deleted the fix/conditional-fetch-cache branchNovember 19, 2025 01:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

@emrysalemrysalemrysal approved these changes

Assignees

No one assigned

Labels

corearea: core, team members onlyfoundationready-for-e2esize/XL

Projects

None yet

Milestone

v6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@volnei@emrysal@keithwillcode

[8]ページ先頭

©2009-2025 Movatter.jp