- Notifications
You must be signed in to change notification settings - Fork3.4k
Add a test case for invisible validation issue.#18321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:5.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I converted it to a draft so it can't be mistakenly merged |
I didnt get any feedback on this since April. |
| $this->assertFalse($result); | ||
| // There should be errors here, due to comment not being savable. | ||
| debug($article->getErrors()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah this doesn't look right to me. If the save failed there should be an error available. Without that the developer and end user have no idea what is wrong.
Uh oh!
There was an error while loading.Please reload this page.
Is this a valid test case for the scenario in#18241 ?
It does not show any error messages that we can display the user in the form or give back via flash message.
But I think somehow we should be able to do that, otherwise domain rule validation is even less useful compared to normal validation.
NOTE: DO NOT MERGE, this requires still some of of fix and assert.