- Notifications
You must be signed in to change notification settings - Fork118
Add support for protobuf in default data converter#335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
meiliang86 commentedJul 8, 2019
| Objectvalue =values[0]; | ||
| if (valueinstanceofGeneratedMessageV3) { | ||
| GeneratedMessageV3protoObj = (GeneratedMessageV3)value; | ||
| returnprotoObj.toByteArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think by default we want to serialize it to JSON to make it UI friendly:https://github.com/protocolbuffers/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java
CLAassistant commentedApr 7, 2022
Liang Mei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
No description provided.