- Notifications
You must be signed in to change notification settings - Fork118
Add CronoverlapPolicy support to java client, update idl#1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
| privateStringcronSchedule; | ||
| privateintcronOverlapPolicy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use thrift entity similar toWorkflowIdReusePolicy
| privateDurationdelayStart; | ||
| privateintcronOverlapPolicy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use thrift entity
| privateStringcronSchedule; | ||
| privateintcronOverlapPolicy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use thrift entity
| .setRetryOptions(RetryOptions.merge(methodRetry,o.getRetryOptions())) | ||
| .setCronSchedule(OptionsUtils.merge(cronAnnotation,o.getCronSchedule(),String.class)) | ||
| .setMemo(o.getMemo()) | ||
| .setCronOverlapPolicy(o.cronOverlapPolicy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use getter
Uh oh!
There was an error while loading.Please reload this page.
What changed?
Updated IDL submodule to latest master
Added
cronOverlapPolicyfield to support cron workflow overlap policies in:WorkflowOptions- field with getter, setter, equals, hashCode, toString, mergeStartWorkflowExecutionParameters- field with CRUD operations and propagationStartChildWorkflowExecutionParameters- field with CRUD operationsChildWorkflowOptions- field with getter, setter, mergeSyncDecisionContext- updated to pass field to child workflow parametersHowever, this feature is not yet working since idl related change is not merged (will be added in a later pr)
Why?
need to add corresponding logic for
cronOverlapPolicythat is already implemented in server and go clientHow did you test it?
unit tests
Potential risks
Release notes
Documentation Changes