- Notifications
You must be signed in to change notification settings - Fork248
temporarily remove C#variants runtime test#963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Despite earlier efforts to tame the dreaded "return pointer not aligned" issue,it's still happening, even though generated code appears to be correct(e.g. using `ulong` for 64-bit alignment). I'm removing that test until we getto the bottom of it.Signed-off-by: Joel Dice <joel.dice@fermyon.com>
jsturtevant approved these changesJun 3, 2024
Collaborator
jsturtevant left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/lgtm
alexcrichton approved these changesJun 3, 2024
Member
alexcrichton left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
dicej added a commit to dicej/wit-bindgen that referenced this pull requestJul 2, 2024
…ce#963)"This reverts commit3ca7739.As ofdotnet/runtimelab#2609, the "return pointer notaligned" issue which forced us to remove the C# `variants` runtime test case_should_ be resolved. 🤞Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej added a commit to dicej/wit-bindgen that referenced this pull requestJul 8, 2024
…ce#963)"This reverts commit3ca7739.As ofdotnet/runtimelab#2609, the "return pointer notaligned" issue which forced us to remove the C# `variants` runtime test case_should_ be resolved. 🤞Signed-off-by: Joel Dice <joel.dice@fermyon.com>
github-merge-queuebot pushed a commit that referenced this pull requestJul 8, 2024
* Revert "temporarily remove C# `variants` runtime test (#963)"This reverts commit3ca7739.As ofdotnet/runtimelab#2609, the "return pointer notaligned" issue which forced us to remove the C# `variants` runtime test case_should_ be resolved. 🤞Signed-off-by: Joel Dice <joel.dice@fermyon.com>* update C# variants test to match latest code generatorSigned-off-by: Joel Dice <joel.dice@fermyon.com>---------Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite earlier efforts to tame the dreaded "return pointer not aligned" issue, it's still happening, even though generated code appears to be correct (e.g. using
ulongfor 64-bit alignment). I'm removing that test until we get to the bottom of it.