Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

wasi-nn: update the ort library#12162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tamaroning wants to merge3 commits intobytecodealliance:main
base:main
Choose a base branch
Loading
fromtamaroning:fix/2025-12-12

Conversation

@tamaroning
Copy link

@tamaroningtamaroning marked this pull request as ready for reviewDecember 12, 2025 14:15
@tamaroningtamaroning requested review froma team ascode ownersDecember 12, 2025 14:15
@tamaroningtamaroning requested review fromcfallin and removed request fora teamDecember 12, 2025 14:15
@tamaroning
Copy link
Author

Can someone tell me how to fix CI to pass?

@cfallin
Copy link
Member

The failing CI job is right to fail: it's indicating that pulling in the new library requires new vetting. One of the core team members will have to do acargo vet.

I'm tagged as reviewer here but I have some high-priority stuff on my plate at the moment so it may not be until sometime next week when I get to this, sorry!

Copy link
Member

@cfallincfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alright, I had some time to do the vets and the changes here look good. Thanks!

@tamaroning
Copy link
Author

Understand. Thank you!

@cfallin
Copy link
Member

@tamaroning I think this needs a Cargo.lock update as well (see the CI failures); would you mind doing that by doingcargo check orcargo build and then adding the updates as a new commit? (Please do not alter my vet commit;0da9d0b needs to remain on this branch.)

@tamaroning
Copy link
Author

Hi, I rancargo update at your commit but nothing in Cargo.lock changed.
Do you meancargo update?

auto-merge was automatically disabledDecember 13, 2025 19:03

Head branch was pushed to by a user without write access

@cfallin
Copy link
Member

Hi, I rancargo update at your commit but nothing in Cargo.lock changed. Do you meancargo update?

No, I didn't meancargo update -- that pulls in new versions that require more vets. Would you mind force-pushing back to the prior commit to remove your latest one? (i.e., start from0da9d0b again)

Please see the CI job failurehere: that is showing that after running severalcargo check commands on different crates, the lockfile is modified. You'll need to reproduce that and then create a new, separate commit on top with those changes.

@tamaroning
Copy link
Author

Hi, I reset my local branch to0da9d0b and ran allcargo check ...s and./ci/vendor-wit.sh in the Monolith checks CI, but could not reproduce the diff in Cargo.lock.
Am I missing something?

@cfallin
Copy link
Member

Hmm, I wasn't able to reproduce that either. I re-triggered the CI jobs to see if it was some transient version issue (e.g. maybe a release ofsmallvec happened partway through the run or something?).

@cfallin
Copy link
Member

OK, that didn't work, and the new failures don't seem reproducible either. I think at this point I need to ask our resident CI herder@alexcrichton (when he's back in office) for help...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cfallincfallincfallin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to compilewasmtime-wasi-nn with onnx support

2 participants

@tamaroning@cfallin

[8]ページ先頭

©2009-2025 Movatter.jp