Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

Update LLVM to 21.1.2.#4654

Open
wffurr wants to merge 2 commits intobytecodealliance:mainfrom
wffurr:update-llvm
Open

Update LLVM to 21.1.2.#4654
wffurr wants to merge 2 commits intobytecodealliance:mainfrom
wffurr:update-llvm

Conversation

@wffurr
Copy link
Contributor

This required minor changes to LLVMContext construction and PGOOptions.

"repo": "https://github.com/espressif/llvm-project.git",
"repo_ssh": "git@github.com:espressif/llvm-project.git",
"branch": "xtensa_release_18.1.2",
"branch": "xtensa_release_21.1.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no such a branch availabile

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks - I should have checked that. Looks like the new API for LLVMContext construction will have to get wrapped in an #ifdef LLVM version check, since xtensa's latest release is only LLVM 19.

@wffurrwffurrforce-pushed theupdate-llvm branch 2 times, most recently fromc11c325 to0a7e444CompareOctober 2, 2025 18:03
Wraps the LLVMContext construction in LLVM 21 version check; LLVM 21 makes abreaking change in LLVMContext construction, but WAMR still needs tosupport older LLVM versions, e.g. for xtensa/esp32 support which is onlyavailable in at most LLVM 19.
@wffurr
Copy link
ContributorAuthor

Is this good to merge? The test failures look like timeouts; one error is "fatal error: error writing to /tmp/cckAF38s.s: No space left on device" which doesn't seem relevant. Thanks!

@yamt
Copy link
Contributor

yamt commentedOct 6, 2025

Is this good to merge? The test failures look like timeouts; one error is "fatal error: error writing to /tmp/cckAF38s.s: No space left on device" which doesn't seem relevant. Thanks!

isn't it possible llvm 21 build actually somehow requires more space and caused ENOSPC on the ci?
i guess someone needs to investigate a bit further. (sorry i have no time right now)

LLVM 21 update uses more disk space and makes the standard runner failwith "No space left on device".  Using the [free disk spaceaction](https://github.com/marketplace/actions/free-disk-space-ubuntu)to delete the unused Android, Haskell, and .NET runtimes frees up spaceon the runner.
@wffurr
Copy link
ContributorAuthor

wffurr commentedOct 6, 2025•
edited
Loading

Is this good to merge? The test failures look like timeouts; one error is "fatal error: error writing to /tmp/cckAF38s.s: No space left on device" which doesn't seem relevant. Thanks!

isn't it possible llvm 21 build actually somehow requires more space and caused ENOSPC on the ci? i guess someone needs to investigate a bit further. (sorry i have no time right now)

I found a script to free up disk space on the GitHub Ubuntu runner. Is that OK to use? Seems to fix the out of space error. If you'd prefer I didn't use the action from the marketplace, I can hoist that bit out into a script in the WAMR repo and use that instead.

@lum1n0us
Copy link
Contributor

@yamt@TianlongLiang@loganek What are your thoughts on upgrading LLVM to version 21?

@yamt
Copy link
Contributor

@yamt@TianlongLiang@loganek What are your thoughts on upgrading LLVM to version 21?

i don't have strong opinions either ways.
it's a bit sad to use different versions for different targets. but i guess it doesn't matter much.
otoh, i don't see any strong reasons to update to 21 either.

@TianlongLiang
Copy link
Contributor

For ARC, I don't think we should upgrade LLVM to 21.x. For the default target, we do need to update static pgo-related data structures like inthis pr. Personally, I think we need to update the static PGO first before actually upgrading LLVM.

@wffurr
Copy link
ContributorAuthor

We're using WAMR with LLVM head and have patches for LLVM's changes in 21 and 22 that break WAMR. This is probably not the way the software is intended to be used. I was hoping to update to something closer to head.

I could send the patch for just#if LLVM_VERSION_MAJOR >= 21 inaot_llvm.c instead of updating the LLVM targets in the build script.

algitbot pushed a commit to alpinelinux/aports that referenced this pull requestOct 21, 2025
Building with llvm 21 results in the error below. Support for llvm 21upstream is in progress but does not appear to be ready at this time.Rebuild with llvm 20 for now.```/home/buildozer/aports/community/wasm-micro-runtime/src/wasm-micro-runtime-WAMR-2.3.0/core/iwasm/compilation/aot_llvm.c: In function 'aot_create_comp_context':/home/buildozer/aports/community/wasm-micro-runtime/src/wasm-micro-runtime-WAMR-2.3.0/core/iwasm/compilation/aot_llvm.c:2580:31: error: implicit declaration of function 'LLVMOrcThreadSafeContextGetContext' [-Wimplicit-function-declaration] 2580 |     if (!(comp_ctx->context = LLVMOrcThreadSafeContextGetContext(      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/home/buildozer/aports/community/wasm-micro-runtime/src/wasm-micro-runtime-WAMR-2.3.0/core/iwasm/compilation/aot_llvm.c:2580:29: error: assignment to 'LLVMContextRef' {aka 'struct LLVMOpaqueContext *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 2580 |     if (!(comp_ctx->context = LLVMOrcThreadSafeContextGetContext(      |                             ^```Ref:bytecodealliance/wasm-micro-runtime#4654
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yamtyamtyamt left review comments

@loganekloganekAwaiting requested review from loganek

@lum1n0uslum1n0usAwaiting requested review from lum1n0uslum1n0us is a code owner

@no1wudino1wudiAwaiting requested review from no1wudino1wudi is a code owner

@TianlongLiangTianlongLiangAwaiting requested review from TianlongLiangTianlongLiang is a code owner

@wenyonghwenyonghAwaiting requested review from wenyongh

@xujuntwt95329xujuntwt95329Awaiting requested review from xujuntwt95329

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wffurr@yamt@lum1n0us@TianlongLiang
[8]ページ先頭
©2009-2026 Movatter.jp