- Notifications
You must be signed in to change notification settings - Fork1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Horizontal scrollable table ignores column width (#3726)#3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Fixes the issue that `BTable` ignored column widths if there were more columns than fitting in a page. Applies the `width` to the child `<div >` of `<th>` to enforce the `width`. `BTableColumn` introduces a new computed property `thWrapStyle` that is applied to `th-wrap` elements. Unfortunately, `<table>` may ignore `width` unless `table-layout` is fixed. `table-layout: fixed`, however, requires an explicit table width to work and is not always relevant. The workaround is inspired by the following StackOverflow comment: -https://stackoverflow.com/questions/18503849/set-min-width-in-html-tables-td#comment27205973_18503849 Fortunately, `BTable` had `<div>` inside all the `<th>` elements. So I decided to apply `width` to those elements.issuebuefy#3726
✅ Deploy Preview forbuefy-org ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
64 tasks
kikuomax added a commit to kikuomax/buefy that referenced this pull requestJan 10, 2024
- Fixes the issue that `BTable` ignored column widths if there were more columns than fitting in a page. Applies the `width` to the child `<div >` of `<th>` to enforce the `width`. `BTableColumn` introduces a new computed property `thWrapStyle` that is applied to `th-wrap` elements. Unfortunately, `<table>` may ignore `width` unless `table-layout` is fixed. `table-layout: fixed`, however, requires an explicit table width to work and is not always relevant. The workaround is inspired by the following StackOverflow comment: -https://stackoverflow.com/questions/18503849/set-min-width-in-html-tables-td#comment27205973_18503849 Fortunately, `BTable` had `<div>` inside all the `<th>` elements. So I decided to apply `width` to those elements.issuebuefy#3726- Includes an additional fix for buefy-next: - `mockTableColumn` also provides `thWrapStyle`
kikuomax added a commit to kikuomax/buefy that referenced this pull requestFeb 11, 2024
- Fixes the issue that `BTable` ignored column widths if there were more columns than fitting in a page. Applies the `width` to the child `<div >` of `<th>` to enforce the `width`. `BTableColumn` introduces a new computed property `thWrapStyle` that is applied to `th-wrap` elements. Unfortunately, `<table>` may ignore `width` unless `table-layout` is fixed. `table-layout: fixed`, however, requires an explicit table width to work and is not always relevant. The workaround is inspired by the following StackOverflow comment: -https://stackoverflow.com/questions/18503849/set-min-width-in-html-tables-td#comment27205973_18503849 Fortunately, `BTable` had `<div>` inside all the `<th>` elements. So I decided to apply `width` to those elements.issuebuefy#3726- Includes an additional fix for buefy-next: - `mockTableColumn` also provides `thWrapStyle`
kikuomax added a commit to ntohq/buefy-next that referenced this pull requestFeb 12, 2024
- Fixes the issue that `BTable` ignored column widths if there were more columns than fitting in a page. Applies the `width` to the child `<div >` of `<th>` to enforce the `width`. `BTableColumn` introduces a new computed property `thWrapStyle` that is applied to `th-wrap` elements. Unfortunately, `<table>` may ignore `width` unless `table-layout` is fixed. `table-layout: fixed`, however, requires an explicit table width to work and is not always relevant. The workaround is inspired by the following StackOverflow comment: -https://stackoverflow.com/questions/18503849/set-min-width-in-html-tables-td#comment27205973_18503849 Fortunately, `BTable` had `<div>` inside all the `<th>` elements. So I decided to apply `width` to those elements.issuebuefy#3726- Includes an additional fix for buefy-next: - `mockTableColumn` also provides `thWrapStyle`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
widthstyle to<div>in<th>.thWrapStyletoBTableColumn