- Notifications
You must be signed in to change notification settings - Fork1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix: b-button nativeType for tag 'input'#3859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
kikuomax approved these changesNov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have confirmed the fix with the following code:
<template> <div> <b-buttontag="input"native-type="submit">Submit</b-button> </div></template>
64 tasks
kikuomax added a commit to kikuomax/buefy that referenced this pull requestJan 10, 2024
- Includes migration to Vue Test Utils v2: - Awaits `setProps`Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
This was referencedJan 24, 2024
kikuomax added a commit to kikuomax/buefy that referenced this pull requestFeb 11, 2024
- Includes migration to Vue Test Utils v2: - Awaits `setProps`Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
kikuomax added a commit to ntohq/buefy-next that referenced this pull requestFeb 12, 2024
- Includes migration to Vue Test Utils v2: - Awaits `setProps`Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use nativeType for b-button with tag 'input' and type 'submit' after pull request with disabling nativeType for tag 'a' (#3733).
In this pull request I fixed it.