- Notifications
You must be signed in to change notification settings - Fork1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix check to display Autocomplete#3963
Conversation
Display Autocomplete list if footer slot is registered
✅ Deploy Preview forbuefy-org ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
@GMartigny I tested the behavior with the following code: <template> <divclass="container is-max-desktop"> <b-fieldlabel="Only footer"> <b-autocomplete:data="[]"> <template #footer> <a><span>Add new...</span></a> </template> </b-autocomplete> </b-field> </div></template> Without your PR: no dropdown showed up With your PR: the dropdown with "Add new..." footer showed up Thanks for your PR! Please attach any reproduction code next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me!
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
Display Autocomplete list if footer slot is registered
Proposed Changes