Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: store sales summary#6836

Draft
IzyPro wants to merge 1 commit intobtcpayserver:masterfrom
IzyPro:store-sales-summary
Draft

feat: store sales summary#6836
IzyPro wants to merge 1 commit intobtcpayserver:masterfrom
IzyPro:store-sales-summary

Conversation

@IzyPro
Copy link
Contributor

feat: Store Sales Summary
Time-based store specific sales metrics 
Provides API endpoint forbtcpayserver/app#91 andbtcpayserver/app#107

image

dstrukt reacted with heart emoji
@coderabbitai
Copy link
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@IzyPro
Copy link
ContributorAuthor

@NicolasDorier do let me know if this concept is in alignment
If yes, i'd proceed with documentation and tests. Otherwise, let me know what needs to change

@dstrukt
Copy link
Member

!!!

Excited to see this one come together.

IzyPro reacted with rocket emoji

Refunds = invoices.Sum(x => x.Refunds.Count),
SalesCount = invoices.LongLength,
Currency = invoices.FirstOrDefault()?.GetPayments(false)?.FirstOrDefault()?.Currency,
Taxes = invoices.Sum(x => x.TaxInPaymentCurrency()),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why are you using payment currency here?
You are summing amounts that may be in different currencies. Not only payments can be in different currencies, but invoices too. So you can't just sum them.

@NicolasDorier
Copy link
Member

NicolasDorier commentedJul 10, 2025•
edited
Loading

@IzyPro if this is for the app, I think you should rather expose this API in the plugin of the app than in Core.
In Core, we should make an API over the concept of reports that we already have.

Reports also have summaries, though they are calculated client side currently, so some non trivial work would need to be done for an endpoint that expose only the summaries.

However, your API as is isn't good, even in the plugin. See my comment (you are adding different currencies together)

@IzyPro
Copy link
ContributorAuthor

Alright
I will look at the concept of reports that we already have and find a way to work that into the app

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NicolasDorierNicolasDorierNicolasDorier left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IzyPro@dstrukt@NicolasDorier

Comments

[8]ページ先頭
©2009-2026 Movatter.jp