Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use w3c protocol with latest client version#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
avinash-bharti wants to merge10 commits intomaster
base:master
Choose a base branch
Loading
fromw3c

Conversation

@avinash-bharti
Copy link
Collaborator

@avinash-bhartiavinash-bharti commentedAug 25, 2022
edited
Loading

JIRAhttps://browserstack.atlassian.net/browse/ASI-4227
This PR:

  • Use latest appium client version
  • replace deprecated methods and locators
  • Use w3c configuration
  • updates information about appium version in readme

@avinash-bhartiavinash-bharti marked this pull request as ready for reviewAugust 25, 2022 20:46
Copy link
Collaborator

@kamal-kaur04kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can have a single Base Class for all the three tests by leveraging<parameter> (can add conf.json file) tag intestng.xml config.

Copy link
Collaborator

@kamal-kaur04kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need to update README.md as we have removed separate directories. Can mention the direct command to run the test.

Copy link
Collaborator

@kamal-kaur04kamal-kaur04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link

@TommybioTommybio left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi java.net

Tommybio reacted with eyes emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kamal-kaur04kamal-kaur04kamal-kaur04 approved these changes

+1 more reviewer

@TommybioTommybioTommybio left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avinash-bharti@kamal-kaur04@Tommybio

[8]ページ先頭

©2009-2025 Movatter.jp