Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork245
Fix __signature__ support if object has a __file__#992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedJul 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Pleaseinstall the Github App Integration for your organization.Read more. @@ Coverage Diff @@## main #992 +/- ##==========================================- Coverage 76.36% 76.35% -0.01%========================================== Files 61 61 Lines 8284 8291 +7 ==========================================+ Hits 6326 6331 +5- Misses 1958 1960 +2
|
Could you please add a test case covering such a class? |
I updated the previous test to test this edge case :p |
Followup to#932. I missed an edge-case :(
If a class uses exotic
__signature__typings, but also has a__file__(thatinspect.getsourcelinesfinds), then it is ignored whenever_fix_default_valuesdoesn't work. In this case it should just 'trust' the__signature__.