Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork252
Mypy types for autocomplete.py, args.py, config.py and curtsies.py#929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Running mypy in CI on this one file.
codecov-commenter commentedOct 7, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #929 +/- ##==========================================+ Coverage 68.02% 68.05% +0.02%========================================== Files 61 61 Lines 9199 9229 +30 ==========================================+ Hits 6258 6281 +23- Misses 2941 2948 +7
Continue to review full report at Codecov.
|
sebastinas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! I just have some small comments which could be addressed before merging the branch.Optional[X] for return types is probably more of a style preference instead.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
mypynow checks the whole package... but only these 4 files have these pragmas which require functions to have type annotations:The way to run this locally is
but you need to install some things first:
You may also need to upgrade curtsies if you haven't installed it fresh because I made the types a little more lenient.