Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork245
Feature: Add open close parentheses for attribute suggestions that are methods#840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I personally like this, and I think at least the second part, attribute completion changes, should be added. |
codecov-commenter commentedJul 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #840 +/- ##==========================================- Coverage 67.95% 67.76% -0.20%========================================== Files 61 61 Lines 9144 9154 +10 ==========================================- Hits 6214 6203 -11- Misses 2930 2951 +21
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading.Please reload this page.
TLDR:
Sorry for the bad quality gifs. I should stop using GIPHY for this.
Native function completion


Current behavior: open parenthesis in suggestion and autofill. You have to type something after the paren before you can see the method signature.
My proposal: open AND close parens in suggestion, no parens in autofill. Now typing the open paren shows the method signature.
This might mess with some people's muscle memory since it changes what's autofilled.
Attributute completion


Current behavior: no parens in suggestion or autofill. You can't tell what is a method or otherwise.
My proposal: open close parens in suggestion, no parens in autofill. Very clear which attrs are methods.
Since this only changes the infobox, it shouldn't mess with anyone's muscle memory.
If this seems worth implementing, I'll need to fix some tests. Right now, tests expect matches that look like "math.cos" or "any(", but they'll be getting matches that look like "math.cos()" and "any()".
Also I'm not sure if I implemented this the best way. The way I did it, the actual match string is altered to have parens. Maybe it's better to leave the match as-is, but add parenthesis only on the front end. This would require some passing around of information. Feedback appreciated.