Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork252
ImportFinder: Support find_spec interface#836
Merged
sebastinas merged 1 commit intobpython:masterfromJul 31, 2020
Merged
Conversation
Contributor
sebastinas commentedSep 6, 2020
@tbabej Looks like that didn't cover all of it: I've now changed it inafc28c3 to only replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The absence of
ImportFinderwrapping thefind_specmethod (introduced in Python 3.4), which is a successor to now deprecatedfind_module[0] cause one of the finder classes to not find the namespace package, as it is only detectable usingfind_specImplements backwards-compatible logic to support
find_specif present in the Finder being wrapped.Closes#835.
[0]https://docs.python.org/3/library/importlib.html#importlib.abc.MetaPathFinder.find_spec