Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork252
WIP - width aware output take 2#731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
thomasballinger commentedFeb 14, 2018
A requirement for merging this should be identifying exactly what it's fixing. I had thought it might be fixing issues like#670 but that has to do with terminal escapes - this is really only a unicode fix. |
thomasballinger commentedFeb 14, 2018
Another issue: |
ikanobori commentedFeb 14, 2018
Not entirely sure but could you, while you're in this part of the code, see if this also gets resolved:#724 with the patches? |
thomasballinger commentedAug 1, 2020
@rybarczykj knows where this is if we work on this more, I'm closing because even if we do this it won't be with this PR. |
Uh oh!
There was an error while loading.Please reload this page.
The Curtsies version referenced does not exist yet, don't merge.
Perf looks better now, a linear 10x slower. Wonder if this is good enough, I made some guesses about how to make things fast inbpython/curtsies#109 but haven't profiled at all.