Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork252
Change __name__ to '__main__'#692
Closed
afrieder wants to merge 1 commit intobpython:masterfrom
afrieder:__name__
Closed
Change __name__ to '__main__'#692afrieder wants to merge 1 commit intobpython:masterfromafrieder:__name__
afrieder wants to merge 1 commit intobpython:masterfrom
afrieder:__name__
Conversation
ContributorAuthor
afrieder commentedJul 8, 2017
(As you can probably tell by all these PRs, I've been using bpython a lot recently. It's awesome and I thank you so much for all the hard work that's been put in so far) |
Contributor
sebastinas commentedJul 10, 2017
Wouldn't that break |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of other repls (
pythonandipython) is to set__name__to'__main__'. You can test this by simply printing__name__or by running bpython on some file that has a__name__ == '__main__'guard. This was first changed in#506 but as noted in that issue, the original reason for changing has been lost. Since__name__ == '__main__'is so common (it appears 16 times in this codebase alone), it's a significant annoyance to not be able to run files in bpython with that guard. I request you change it back to this more useful behavior.