Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: Handle bpmn:DataInputAssociation and bpmn:DataOutputAssociation according to BPMN 2.0 specification#910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
philippfromme wants to merge4 commits intomain
base:main
Choose a base branch
Loading
from984-data-input-associations

Conversation

philippfromme
Copy link
Contributor

bpmn:DataInputAssociation

  • create bpmn:InputOutputSpecification if not found
  • add bpmn:DataInput element and reference as targetRef of bpmn:DataInputAssociation
  • add bpmn:InputSet and add reference to bpmn:DataInput
  • there will only ever be one bpmn:InputSet
  • always clean up bpmn:InputOutputSpecification and remove if necessary

Example:

<bpmn:taskid="myTask">  <bpmn:incoming>incoming</bpmn:incoming>  <bpmn:ioSpecificationid="myIoSpecification">    <bpmn:dataInputid="myDataInput" />    <bpmn:inputSetid="myInputSet">      <bpmn:dataInputRefs>myDataInput</bpmn:dataInputRefs>    </bpmn:inputSet>  </bpmn:ioSpecification>  <bpmn:dataInputAssociationid="myDataInputAssociation">    <bpmn:sourceRef>someSourceRef</bpmn:sourceRef>    <bpmn:targetRef>myDataInput</bpmn:targetRef>  </bpmn:dataInputAssociation></bpmn:task>

bpmn:DataOutputAssociation

  • create bpmn:InputOutputSpecification if not found
  • add bpmn:DataOutput element and reference as sourceRef of bpmn:DataOutputAssociation
  • add bpmn:OutputSet and add reference to bpmn:DataOutput
  • there will only ever be one bpmn:OutputSet
  • always clean up bpmn:InputOutputSpecification and remove if necessary

Example:

<bpmn:taskid="myTask">  <bpmn:outgoing>outgoing</bpmn:outgoing>  <bpmn:ioSpecificationid="myIoSpecification">    <bpmn:dataOutputid="myDataOutput" />    <bpmn:outputSetid="myOutputSet">      <bpmn:dataOutputRefs>myDataOutput</bpmn:dataOutputRefs>    </bpmn:outputSet>  </bpmn:ioSpecification>  <bpmn:dataOutputAssociationid="myDataOutputAssociation">    <bpmn:sourceRef>myDataOutput</bpmn:sourceRef>    <bpmn:targetRef>someTargetRef</bpmn:targetRef>  </bpmn:dataOutputAssociation></bpmn:task>

Related tocamunda/camunda-modeler#984

ElCondor1969 and danfunk reacted with thumbs up emoji
@ghostghost added the needs reviewReview pending labelNov 23, 2018
@philippfrommephilippfrommeforce-pushed the984-data-input-associations branch fromd1533cb tod568d00CompareNovember 23, 2018 12:30
Copy link
Member

@nikkunikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we able to consume<= v3.0.0 style modeled diagrams and migrate them step by step to the new IO representation?

@philippfrommephilippfrommeforce-pushed the984-data-input-associations branch from77d9232 tof2d4870CompareNovember 27, 2018 17:46
@ElCondor1969
Copy link
Contributor

This feature is really necessary. More or less, when do you expect the changes to be merged into main?

@nikku
Copy link
Member

This feature is really necessary.

Please provide us with a little bit more context. Why is this featurereally necessary?

@ElCondor1969
Copy link
Contributor

Hi Nikku.
I'm sorry, I may not have been very clear.
I meant the functionality illustrated by Philipp at the beginning of PR, that is the use, according to the BPMN 2.0 standard, of the tag "DataInputAssociation" and "DataOutputAssociation".
Since the PR has not yet been merged into the master, I wondered if there was a closing date for this PR.
If I understand your question correctly.
Bye.

Please provide us with a little bit more context. Why is this featurereally necessary?

@nikku
Copy link
Member

I'm askingwhy the feature is important for you and notwhat. An answer to that question helps us to better evaluate the demand.

@ElCondor1969
Copy link
Contributor

I'm askingwhy the feature is important for you and notwhat. An answer to that question helps us to better evaluate the demand.

Hi Nikku.

If I understand the purpose of Philipp's PR, this feature is important because it would allow you to manage the associations between data and tasks through theioSpecification tag and itsdataInput /dataOutput as it should be.
For a better explanation, let's consider the following trivial diagram:

diagram

Currently the editor produces, fortask 1, the following XML:

<bpmn:task name="Task"> <bpmn:incoming>SequenceFlow_0iu53jb</bpmn:incoming> <bpmn:outgoing>SequenceFlow_0mz7m8s</bpmn:outgoing> <bpmn:property name="__targetRef_placeholder" /> <bpmn:dataInputAssociation> <bpmn:sourceRef>DataObjectReference_1</bpmn:sourceRef> <bpmn:targetRef>Property_05b30xr</bpmn:targetRef> </bpmn:dataInputAssociation> </bpmn:task>

As you can see, the editor created aproperty tag instead of using adataInput tag within aioSpecification tag.
In my opinion, it would be better to use adataInput because, logically, the data converge as input data within the task to undergo some processing.

If I understood correctly, and I'm not wrong, it seems to me that the PR submitted by Philippe should solve this case too.

Bye.

@philippfromme
Copy link
ContributorAuthor

That still doesn't answer the question. Obviously this PR would ensure compatibility with the BPMN 2.0 specification. The question is: What is your use case that requires this compatibility? What are you trying to do?

@ElCondor1969
Copy link
Contributor

Hi, Philipp.
From the fact that you still have not understood what I meant by my last post, I am convinced that I have not understood the aims of this PR.
Please ignore my previous posts.
When I have more time, in the future, I will create a special Issue and there I will explain well what, in my opinion, it would be useful to implement to adhere more to the BPMN 2.0 standard with regard to tasks and the association with data objects.

That still doesn't answer the question. Obviously this PR would ensure compatibility with the BPMN 2.0 specification. The question is: What is your use case that requires this compatibility? What are you trying to do?

@nikku
Copy link
Member

When I have more time, in the future, I will create a special Issue and there I will explain well what, in my opinion, it would be useful to implement to adhere more to the BPMN 2.0 standard with regard to tasks and the association with data objects.

We second your opinion and may some day maybe improve handling of IO mappings in the future.

@nikkunikku added readyReady to be worked on backlogQueued in backlog and removed needs reviewReview pending readyReady to be worked on labelsFeb 12, 2019
@nikkunikku changed the titleHandle bpmn:DataInputAssociation and bpmn:DataOutputAssociation according to BPMN 2.0 specificationWIP: Handle bpmn:DataInputAssociation and bpmn:DataOutputAssociation according to BPMN 2.0 specificationOct 18, 2022
@nikkunikku marked this pull request as draftDecember 12, 2022 22:59
@bpmn-io-tasksbpmn-io-tasksbot added in progressCurrently worked on and removed backlogQueued in backlog labelsDec 12, 2022
@nikkunikku added the backlogQueued in backlog labelDec 12, 2022 — withbpmn-io-tasks
@nikkunikku removed the in progressCurrently worked on labelDec 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nikkunikkunikku left review comments

Assignees
No one assigned
Labels
backlogQueued in backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@philippfromme@ElCondor1969@nikku

[8]ページ先頭

©2009-2025 Movatter.jp