- Notifications
You must be signed in to change notification settings - Fork1.4k
1513 dynamic resizing labels#2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
1513 dynamic resizing labels#2345
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedAug 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
| }); | ||
| functiongetTextHeightForTextAnnotation(event){ | ||
| returnevent.gfx.firstChild.lastChild.lastChild.y.animVal[0].value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure how to make this look nicer. If you know another way, please show me with a pointer.
Hi, thanks for your contribution. We will look into this soon. |
Some interactions don't work properly or are not intuitive, so there's still some work ahead. I'd expect that the horizontal resize snaps to the text width. The label jump on vertical resize is also unintuitive. Screen.Recording.2025-09-10.at.11.43.31.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a test for horizontal resize as it's clearly not working correctly. The feature is useful, but we need to make sure it works correctly.
Uh oh!
There was an error while loading.Please reload this page.
Proposed Changes
This pull request concerns dynamic resizing of text fields. To this end, labels have been made resizable and code has been added that adjusts the height of the text to match the width.
Closes#1513
Visual demo
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}