- Notifications
You must be signed in to change notification settings - Fork1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Download tar archives from https://github when possible#2263
Conversation
@bower/contributors Please review and test |
ptitgraig commentedApr 23, 2016
Looking at it. |
Even though I couldn't replicate the issue, the code still looks like the solution. |
ptitgraig commentedApr 27, 2016
Sorry, taking time to understand. Not really at ease with bower architecture yet. |
By the way, we need to make sure bower is working for old git versions (e.g. there is no blocking in interactive mode when repository doesn't exist..) |
For me it is pulling fromhttps://github (instead of git://) with this change. |
small point: |
be95ea8
to39ed77a
CompareThisfixes#2247 as git checkout often fails on older git versions.Additionally .tar.gz archives are downloaded for commits and branches.
ankon commentedNov 11, 2016
FWIW: This change nicely broke all our setups in Travis that had bower get stuff from private repositories. Previously we needed this configuration to make sure SSH authentication is used:
With the change in resolvers we now have to fix all configurations to have redirects for both git:// and https://. |
Thisfixes#2247 as git checkout often fails on older git versions.
Additionally .tar.gz archives are downloaded for commits and branches.