Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork171
Fix tooltip directive interfering with button group styling#2844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/fix-1911
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+105 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
|
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
CopilotAI changed the title[WIP] Buttongroup: last button/dropdown loses rounding if using v-b-tooltipFix tooltip directive interfering with button group stylingSep 15, 2025
Copilot finished work on behalf ofVividLemonSeptember 15, 2025 13:55
Contributor
This PR is stale because it has been open for 45 days with no activity. It will not be auto-closed |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
staleThere has been no additional replies or questions and the thread is assumed closed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When a
BButtonorBDropdownwithv-b-tooltipis placed as the last element in aBButtonGroup, the right-side border radius disappears, breaking the visual consistency of the button group.Root Cause
The issue occurs because the tooltip directive inserts a
<span>element as the next sibling of the button element. This breaks Bootstrap's CSS:last-childselectors that applyborder-radiusto the last button in a group:Before fix:
Solution
Modified the
vBTooltipdirective to automatically detect when an element is inside a button group (using the existingbuttonGroupKeyinjection) and use body placement for tooltips in button groups. This prevents DOM interference while maintaining full tooltip functionality.After fix:
Changes
vBTooltipdirective to detect button group contextVisual Result
All button groups now maintain proper rounded corners regardless of tooltip placement, while tooltips remain fully functional.
Fixes#1911.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.