Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork171
Comparing changes
Open a pull request
base repository:bootstrap-vue-next/bootstrap-vue-next
Uh oh!
There was an error while loading.Please reload this page.
base:main
head repository:bootstrap-vue-next/bootstrap-vue-next
Uh oh!
There was an error while loading.Please reload this page.
compare:copilot/fix-2848
Uh oh!
There was an error while loading.Please reload this page.
- 7commits
- 6files changed
- 3contributors
Commits on Sep 22, 2025
Fix useModal reactivity warning for custom components
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Add playground example demonstrating the fix
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Commits on Nov 19, 2025
Remove unnecessary markRaw calls in shallowRef
Per@VividLemon's review feedback, shallowRef alone is sufficient to preventthe reactive component warning. The markRaw calls in the shallowRef initializationwere redundant and can be removed, simplifying the code while maintaining the fix.Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Commits on Nov 30, 2025
Simplify shallowRef usage by removing unnecessary toValue and spread
Addressed@xvaara's feedback: when obj is not a ref, we can pass it directlyto shallowRef() without needing toValue() and spread operators.Co-authored-by: xvaara <130606+xvaara@users.noreply.github.com>
Apply same shallowRef fix to useToast and usePopover composables
Updated useToast and usePopover to use the same pattern as useModal:- Changed `toRef(obj)` to `isRef(obj) ? obj : shallowRef(obj)`- Replaced toRef import with shallowRef importThis prevents the Vue reactivity warning for custom components in allorchestrator composables.Co-authored-by: xvaara <130606+xvaara@users.noreply.github.com>
Merge main branch changes: add generics support while keeping shallow…
…Ref fixThis merges the new generic ComponentProps type support from main (#2922)with our shallowRef fix to prevent Vue reactivity warnings for customcomponents in orchestrator composables.Co-authored-by: xvaara <130606+xvaara@users.noreply.github.com>
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff main...copilot/fix-2848
Uh oh!
There was an error while loading.Please reload this page.