Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-button): add aria-disabled attribute when explicitly set#7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(b-button): add aria-disabled attribute when explicitly set#7190
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
codesandbox-cibot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. |
codecovbot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## dev #7190 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 305 305 Lines 10453 10454 +1 Branches 2551 2552 +1 =========================================+ Hits 10453 10454 +1
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
71f66f9
to8106b61
Compare@xanf can you take a look at this when you have time? 🙂 |
arturoherrero commentedJan 18, 2024
@xanf@VividLemon Can you review this, please? |
@arturoherrero I will be able to do that somewhere next week |
arturoherrero commentedApr 1, 2024
503c74f
intobootstrap-vue:devUh oh!
There was an error while loading.Please reload this page.
Describe the PR
Discussed in#6678
Currently it is not possible to explicitly set
aria-disabled
attribute onb-button
, this PR fixes that bug.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.).This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: