Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(b-calendar): add a parameter to the calendar to display 6 weeks#7155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Tarrask wants to merge2 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromPlumettaz:dev

Conversation

Tarrask
Copy link
Contributor

@TarraskTarrask commentedJun 9, 2023
edited
Loading

Describe the PR

This parameter will force the calendar to display 6 weeks, even when the month cover only 5 weeks. This prevent any layout shift when navigating from month to month.

This is also a fix for#5326

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • x] Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

…weeksThis parameter will force the calendar to display 6 weeks, even when themonth cover only 5 weeks. This prevent any layout shift when navigatingfrom month to month.
@vercel
Copy link

vercelbot commentedJun 9, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
bootstrap-vue✅ Ready (Inspect)Visit Preview💬Add feedbackJul 28, 2023 8:48am

@codesandbox-ci
Copy link

codesandbox-cibot commentedJun 9, 2023
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit0707844:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@codecov
Copy link

codecovbot commentedJun 9, 2023
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base(5173dd1) to head(0707844).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@##               dev     #7155   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          305       305             Lines        10453     10453             Branches      2551      2551           =========================================  Hits         10453     10453
FlagCoverage Δ
unittests100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@TarraskTarrask marked this pull request as ready for reviewJune 12, 2023 07:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Tarrask

[8]ページ先頭

©2009-2025 Movatter.jp