Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-form-input): allow prevent default for wheel event#7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
HarmvZ wants to merge3 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromHarmvZ:7124-fix-prevent-default-wheel-number-input

Conversation

HarmvZ
Copy link

Describe the PR

Fixes#7124.

Seehttps://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#improving_scrolling_performance_with_passive_listeners. In browsers other than Safari and IE any wheel event attached to the document will be set topassive: true by default which does not allowpreventDefault and causes the error. This PR fixes the issue by explicitly settingpassive: false for the wheel event of the number b-form-input.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

@vercel
Copy link

vercelbot commentedFeb 15, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated
bootstrap-vue✅ Ready (Inspect)Visit Preview💬Add your feedbackFeb 15, 2023 at 9:57AM (UTC)

@codesandbox-ci
Copy link

codesandbox-cibot commentedFeb 15, 2023
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

@codecov
Copy link

codecovbot commentedFeb 15, 2023
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base(46360a7) to head(c85f97b).

Additional details and impacted files
@@           Coverage Diff           @@##              dev    #7125   +/-   ##=======================================  Coverage   99.96%   99.96%           =======================================  Files         305      305             Lines       11206    11206             Branches     2647     2647           =======================================  Hits        11202    11202             Misses          4        4
FlagCoverage Δ
unittests99.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobmllr95jacobmllr95 changed the titlefix(b-form-input): allow prevent default for wheel event (fixes #7124)fix(b-form-input): allow prevent default for wheel eventMar 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when scrolling with no-wheel attribute on a number b-form-input
2 participants
@HarmvZ@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp