Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(docs): update the link to BCP 47#7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jacobmllr95 merged 2 commits intobootstrap-vue:devfromxfq:patch-1
Mar 26, 2025

Conversation

@xfq
Copy link
Contributor

@xfqxfq commentedJul 12, 2022

Describe the PR

tools.ietf.org is no longer to be relied on perhttps://mailarchive.ietf.org/arch/msg/tools-discuss/oYrAxb3KayPzZ4SNB1DVZTDPPNo/

AFAIK, rfc-editor.org is the recommended URL for RFC and BCP nowadays. Also, I changed the link from RFC 5646 to BCP 47 (seehttps://www.w3.org/TR/international-specs/#lang_bcp_not_rfc ).

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercelbot commentedJul 12, 2022
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
bootstrap-vue✅ Ready (Inspect)Visit PreviewJan 7, 2023 at 9:48AM (UTC)

@codesandbox-ci
Copy link

codesandbox-cibot commentedJul 12, 2022
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitc60304b:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@codecov
Copy link

codecovbot commentedJan 7, 2023
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base(3e29c63) to head(c60304b).
Report is 52 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@##               dev     #7009   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          305       305             Lines        10453     10453             Branches      2551      2551           =========================================  Hits         10453     10453
FlagCoverage Δ
unittests100.00% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VividLemon
Copy link
Member

If the recommended standard has changed, then that would assume that there is something on the new that is not supported by bootstrap-vue. You may want to explain a bit more about the scope of what this change is. To clarify, I am fine if this is only adocs change on their part. However, if the spec changed, and we are supposed to be supporting newtags, then linking to some different docs wouldn't be appropriate as it would be misleading.

@xfq
Copy link
ContributorAuthor

xfq commentedJan 24, 2023

This PR just uses the recommended URL of the IETF language tag standard, so if the spec is updated, we don't need to update the URL. This is also the URLrecommended by W3C (for many years):

The link to and name of BCP 47 was created specifically so that there is an unchanging reference to the definition of Tags for the Identification of Languages. RFCs 1766, 3066, 4646 were previous (superseded) versions and 5646 is the current version of BCP 47.

In terms of content, RFC 5646 is just the core of BCP 47, so bootstrap-vue doesn't need to update any code. It doesn't introduce new language tags either, because the language subtags are managed by theIANA Subtag Registry.

@jacobmllr95jacobmllr95 merged commitfd586c0 intobootstrap-vue:devMar 26, 2025
@xfqxfq deleted the patch-1 branchMarch 26, 2025 06:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xfq@VividLemon@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp