Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
chore(docs): update the link to BCP 47#7009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedJul 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
codesandbox-cibot commentedJul 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitc60304b:
|
codecovbot commentedJan 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## dev #7009 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 305 305 Lines 10453 10453 Branches 2551 2551 ========================================= Hits 10453 10453
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VividLemon commentedJan 7, 2023
If the recommended standard has changed, then that would assume that there is something on the new that is not supported by bootstrap-vue. You may want to explain a bit more about the scope of what this change is. To clarify, I am fine if this is only adocs change on their part. However, if the spec changed, and we are supposed to be supporting newtags, then linking to some different docs wouldn't be appropriate as it would be misleading. |
xfq commentedJan 24, 2023
This PR just uses the recommended URL of the IETF language tag standard, so if the spec is updated, we don't need to update the URL. This is also the URLrecommended by W3C (for many years):
In terms of content, RFC 5646 is just the core of BCP 47, so bootstrap-vue doesn't need to update any code. It doesn't introduce new language tags either, because the language subtags are managed by theIANA Subtag Registry. |
Describe the PR
tools.ietf.org is no longer to be relied on perhttps://mailarchive.ietf.org/arch/msg/tools-discuss/oYrAxb3KayPzZ4SNB1DVZTDPPNo/
AFAIK, rfc-editor.org is the recommended URL for RFC and BCP nowadays. Also, I changed the link from RFC 5646 to BCP 47 (seehttps://www.w3.org/TR/international-specs/#lang_bcp_not_rfc ).
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: