Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-tooltip): Updated tooltip to work under shadowDOM#6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rasicoc wants to merge2 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromrasicoc:fix-tooltip-web-component-compatibility

Conversation

rasicoc
Copy link

Describe the PR

Our company heavily uses web components to implement the micro-frontend architecture. Bootstrap-vue is heavily used in our application and we have thus far had to not use tooltips/popovers due to the shadow dom issue. After researching it internally for a while we realized a small adjustment to how the element is checked for DOM attachment and visibility would fix this issue. The "node.isConnected" property is widely supported by browsers and is ShadowDOM aware. The utility methods were created though due to specifically IE11 not supporting that property allowing us to be backward compatible. Wanted to contribute that back to the wider community.

Added to dom utility methods

  • isConnectedToDOM() checks if a target element is in the DOM and will check both Shadow and Regular DOM
  • getShadowRootOrRoot() will return the target's root either the Shadow Root or DOCUMENT.body

Updated isVisibile() dom util to use new isConnectedToDOM() function

Updated the dom.spec.js unit tests for the two new dom utilities
Fixed the dom.spec.js to get the select() and selectAll() tests working

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

shawnstrickland, daless14, and tonyl reacted with thumbs up emoji
Added to dom utility methods- isConnectedToDOM() checks if a target element is in the DOM and will check both Shadow and Regular DOM- getShadowRootOrRoot() will return the target's root either the Shadow Root or DOCUMENT.bodyUpdated isVisibile() dom util to use new isConnectedToDOM() functionUpdated the dom.spec.js unit tests for the two new dom utilitiesFixed the dom.spec.js to get the select() and selectAll() tests working
@vercel
Copy link

vercelbot commentedJun 22, 2022
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
bootstrap-vue✅ Ready (Inspect)Visit PreviewJun 22, 2022 at 5:24PM (UTC)

@codesandbox-ci
Copy link

codesandbox-cibot commentedJun 22, 2022
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit5c169cc:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@codecov
Copy link

codecovbot commentedJun 22, 2022
edited
Loading

Codecov Report

Merging#6997 (752661a) intodev (fab4161) willdecrease coverage by0.01%.
The diff coverage is84.61%.

❗ Current head752661a differs from pull request most recent head5c169cc. Consider uploading reports for the commit5c169cc to get more accurate results

@@             Coverage Diff             @@##               dev    #6997      +/-   ##===========================================- Coverage   100.00%   99.98%   -0.02%===========================================  Files          299      299                Lines        10265    10274       +9       Branches      2527     2530       +3     ===========================================+ Hits         10265    10272       +7- Misses           0        2       +2
FlagCoverage Δ
unittests99.98% <84.61%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
src/utils/dom.js97.50% <80.00%> (-2.50%)⬇️
src/components/tooltip/helpers/bv-tooltip.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefab4161...5c169cc. Read thecomment docs.

Updated tests to get to 100% coverage of changed code + added coverage for isVisible()Tightened the check in the getShadowRootOrRoot() method for document root
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@rasicoc

[8]ページ先頭

©2009-2025 Movatter.jp