Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-tooltip): Updated tooltip to work under shadowDOM#6997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
fix(b-tooltip): Updated tooltip to work under shadowDOM#6997
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Added to dom utility methods- isConnectedToDOM() checks if a target element is in the DOM and will check both Shadow and Regular DOM- getShadowRootOrRoot() will return the target's root either the Shadow Root or DOCUMENT.bodyUpdated isVisibile() dom util to use new isConnectedToDOM() functionUpdated the dom.spec.js unit tests for the two new dom utilitiesFixed the dom.spec.js to get the select() and selectAll() tests working
vercelbot commentedJun 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
codesandbox-cibot commentedJun 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit5c169cc:
|
codecovbot commentedJun 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6997 +/- ##===========================================- Coverage 100.00% 99.98% -0.02%=========================================== Files 299 299 Lines 10265 10274 +9 Branches 2527 2530 +3 ===========================================+ Hits 10265 10272 +7- Misses 0 2 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Updated tests to get to 100% coverage of changed code + added coverage for isVisible()Tightened the check in the getShadowRootOrRoot() method for document root
Describe the PR
Our company heavily uses web components to implement the micro-frontend architecture. Bootstrap-vue is heavily used in our application and we have thus far had to not use tooltips/popovers due to the shadow dom issue. After researching it internally for a while we realized a small adjustment to how the element is checked for DOM attachment and visibility would fix this issue. The "node.isConnected" property is widely supported by browsers and is ShadowDOM aware. The utility methods were created though due to specifically IE11 not supporting that property allowing us to be backward compatible. Wanted to contribute that back to the wider community.
Added to dom utility methods
Updated isVisibile() dom util to use new isConnectedToDOM() function
Updated the dom.spec.js unit tests for the two new dom utilities
Fixed the dom.spec.js to get the select() and selectAll() tests working
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.).This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: