Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(b-dropdown): Sets correctaria-haspopup attribute for the toggle button#6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sharlatta
Copy link
Contributor

@sharlattasharlatta commentedDec 8, 2021
edited
Loading

Describe the PR

Updatesaria-haspopup attribute on the toggle button to be set based on therole property provided for the dropdown popup.

Based on the specs:
https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-haspopup

Authors MUST ensure that the role of the element that serves as the container for the popup content is menu, listbox, tree, grid, or dialog, and that the value of aria-haspopup matches the role of the popup container.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

kosich, yankolovorotny, and lostsatellites reacted with thumbs up emoji
@vercel
Copy link

vercelbot commentedDec 8, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/5swptQjRhKyALGWtPt4mTYFGztxv
✅ Preview:https://bootstrap-vue-git-fork-sharlatta-fix-aria-4909db-bootstrap-vue.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedDec 8, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitd74a924:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

…e buttonthe `aria-haspopup` attribute on the toggle button is set based on the `role` property provided for the dropdown popup
@sharlattasharlattaforce-pushed theFix-aria-haspopup-attr-for-the-dropdown-toggle branch fromf94b832 tob806accCompareDecember 13, 2021 16:40
@codecov
Copy link

codecovbot commentedDec 15, 2021
edited
Loading

Codecov Report

Merging#6865 (d74a924) intodev (d345353) willnot change coverage.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff            @@##               dev     #6865   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          299       299             Lines        10259     10261    +2       Branches      2522      2523    +1     =========================================+ Hits         10259     10261    +2
FlagCoverage Δ
unittests100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
src/components/dropdown/dropdown.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated345353...d74a924. Read thecomment docs.

@xanfxanf merged commitd92c2f1 intobootstrap-vue:devDec 15, 2021
@xanf
Copy link
Member

@sharlatta Thank you so much for your contribution 🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sharlatta@xanf

[8]ページ先頭

©2009-2025 Movatter.jp