Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-dropdown): Sets correctaria-haspopup attribute for the toggle button#6865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(b-dropdown): Sets correctaria-haspopup attribute for the toggle button#6865
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedDec 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/5swptQjRhKyALGWtPt4mTYFGztxv |
codesandbox-cibot commentedDec 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitd74a924:
|
Uh oh!
There was an error while loading.Please reload this page.
…e buttonthe `aria-haspopup` attribute on the toggle button is set based on the `role` property provided for the dropdown popup
f94b832 tob806accComparecodecovbot commentedDec 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6865 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10259 10261 +2 Branches 2522 2523 +1 =========================================+ Hits 10259 10261 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
xanf commentedDec 15, 2021
@sharlatta Thank you so much for your contribution 🚀 |
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
Updates
aria-haspopupattribute on the toggle button to be set based on theroleproperty provided for the dropdown popup.Based on the specs:
https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-haspopup
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: