Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix: replace sass division with multiplication (fixes #6830)#6834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedNov 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/8qZah4whKnQ14td95miJSvR5QQt7 |
codesandbox-cibot commentedNov 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit1510721:
|
z1m1n commentedNov 6, 2021
@jacobmllr95 Please take a look |
AdamGaskins commentedNov 17, 2021
I triumphantly updated my bootstrap version to v4.6.1 before realizing bootstrap-vue had sass division too. Came here to make a PR but@z1m1n beat me too it! Thank you 👏🏻 |
jonybekov commentedDec 5, 2021
Can we please merge this PR? |
sebsonjura commentedDec 8, 2021
get this merged asap please ;) |
panreach commentedDec 15, 2021
Bump |
xanf commentedDec 16, 2021
I'm going to merge this today :) Just need to filter-out extra white-space changes :) |
codecovbot commentedDec 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6834 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10263 10263 Branches 2523 2523 ========================================= Hits 10263 10263
Flags with carried forward coverage won't be shown.Click here to find out more. Continue to review full report at Codecov.
|
xanf commentedDec 17, 2021
@z1m1n thank you for your contribution! I'm happy to merge it 🚀 |
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
Replace Sass division with multiplication (required for sass versions greater than 1.32.13) (fixes#6830)
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed: