Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: replace sass division with multiplication (fixes #6830)#6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xanf merged 1 commit intobootstrap-vue:devfromz1m1n:fix6830
Dec 17, 2021

Conversation

@z1m1n
Copy link
Contributor

@z1m1nz1m1n commentedNov 6, 2021
edited
Loading

Describe the PR

Replace Sass division with multiplication (required for sass versions greater than 1.32.13) (fixes#6830)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change?

  • No
  • Yes

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

AdamGaskins, viglucci, and lucasprograms reacted with hooray emojiviglucci reacted with eyes emoji
@vercel
Copy link

vercelbot commentedNov 6, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/8qZah4whKnQ14td95miJSvR5QQt7
✅ Preview:https://bootstrap-vue-git-fork-z1m1n-fix6830-bootstrap-vue.vercel.app

@z1m1nz1m1n changed the titlefix: replace sass division with multiplication (fixes #6830)fix: replace sass division with multiplication (fixes #6830) (fixes #6830[,#6830])Nov 6, 2021
@z1m1nz1m1n changed the titlefix: replace sass division with multiplication (fixes #6830) (fixes #6830[,#6830])fix: replace sass division with multiplication (fixes #6830[#6830])Nov 6, 2021
@z1m1nz1m1n changed the titlefix: replace sass division with multiplication (fixes #6830[#6830])fix: replace sass division with multiplication (fixes #6830)Nov 6, 2021
@codesandbox-ci
Copy link

codesandbox-cibot commentedNov 6, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit1510721:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@z1m1n
Copy link
ContributorAuthor

@jacobmllr95 Please take a look

@AdamGaskins
Copy link

I triumphantly updated my bootstrap version to v4.6.1 before realizing bootstrap-vue had sass division too. Came here to make a PR but@z1m1n beat me too it! Thank you 👏🏻

z1m1n, scott-buchanan, and lucasprograms reacted with heart emoji

@jonybekov
Copy link

Can we please merge this PR?

panreach reacted with thumbs up emojiAdamGaskins reacted with eyes emoji

@sebsonjura
Copy link

get this merged asap please ;)

panreach reacted with thumbs up emoji

@panreach
Copy link

Bump

@xanf
Copy link
Member

I'm going to merge this today :) Just need to filter-out extra white-space changes :)

lucasprograms, AdamGaskins, lagset, and z1m1n reacted with heart emoji

@codecov
Copy link

codecovbot commentedDec 17, 2021
edited
Loading

Codecov Report

Merging#6834 (017d46c) intodev (abaa1c5) willnot change coverage.
The diff coverage isn/a.

❗ Current head017d46c differs from pull request most recent head1510721. Consider uploading reports for the commit1510721 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@##               dev     #6834   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          299       299             Lines        10263     10263             Branches      2523      2523           =========================================  Hits         10263     10263
FlagCoverage Δ
unittests100.00% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.


Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateabaa1c5...1510721. Read thecomment docs.

@xanf
Copy link
Member

@z1m1n thank you for your contribution! I'm happy to merge it 🚀

z1m1n reacted with heart emoji

@xanfxanf merged commitdd051e9 intobootstrap-vue:devDec 17, 2021
@darrinmn9darrinmn9 mentioned this pull requestJan 10, 2022
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Sass division with multiplication and custom divide() function

6 participants

@z1m1n@AdamGaskins@jonybekov@sebsonjura@panreach@xanf

[8]ページ先頭

©2009-2025 Movatter.jp