Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(b-calendar/b-form-datepicker): add day, month, and year type options (closes #6034)#6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
christianklemp wants to merge9 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromchristianklemp:datepicker-types

Conversation

christianklemp
Copy link

@christianklempchristianklemp commentedOct 7, 2021
edited
Loading

Describe the PR

This pull request adds types to theb-calendar andb-form-datepicker components to support for multiple types of date-related picking inputs. The types includedate (default, and the current date picker),day (days of the week),month (months of the year), andyear (years in a decade). I chose to have the components to keep the value formatting the same no matter what type is selected for consistency. Each instance can then utilize the date as needed and ignore the day, month, or year that aren't relevant for them.

I am working on a project where the month and year picker options will be needed in the near future, so I figured I'd add them for anyone else needing these options. Since the only issue that was open and seemed related didn't appear to be being worked on, I figured I'd jump in and get it done. Our development team has gone all-in on using BootstrapVue and we're wanting to avoid having another dependency just for a month and year picker.

I included days of the week since I was trying to generalize it for multiple use cases and am open to feedback. Tests have been added to cover these new types for both components. The documentation has been updated to include new props and updated wording for existing props that are related to types. Examples have been added for theb-calendar andb-form-datepickerREADME.md files for the documentation site to show users what the different type option experiences are like.

What it looks like

StateDateDayMonthYear
Initialimageimageimageimage
Openimageimageimageimage
Open with selectionimageimageimageimage

Docs

b-calendar

image

b-form-datepicker

image

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Gnapstar reacted with hooray emoji
@vercel
Copy link

vercelbot commentedOct 7, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/FEnq7X5CBhPVavpULYnVrizK9mzW
✅ Preview:https://bootstrap-vue-git-fork-christianklemp-date-d8c445-bootstrap-vue.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedOct 7, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit8a477e8:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@christianklemp
Copy link
Author

@Hiws or@jacobmllr95 any idea why Codacy results are conflicting with what theprettify script updates for formatting? I have tried to update what it calls out but cannot commit those changes since that runs in the pre-commit hook. Any help or advice is appreciated!

@bamfix
Copy link

this would be exactly what i was looking for. looks great and seems to work just fine.
these Codacy issues arent real issues as it seems? only false positive code conventions?

how long does it usually take for something like this to go live in bootstrap vue?
this would make the difference for me between using the calendar from bootstrap vue or another third party package.

sry im new to vue, bootstrap and github.

@stale
Copy link

stalebot commentedApr 27, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@vercel
Copy link

vercelbot commentedApr 28, 2022
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
bootstrap-vue✅ Ready (Inspect)Visit PreviewApr 28, 2022 at 8:59AM (UTC)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@christianklemp@bamfix@Hiws

[8]ページ先頭

©2009-2025 Movatter.jp