Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
feat(utils): add file deep cloning#6668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedJun 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/HKRYvEu3kuE8M9GDVZCpNobHr6VX |
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit66c66c8:
|
The Codacy Static Code Analysis seems to be out of sync with the linter in the project. It's wanting the dangling comma but |
codecovbot commentedJun 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## dev #6668 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10258 10260 +2 Branches 2522 2523 +1 =========================================+ Hits 10258 10260 +2
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Describe the PR
Adds cloning of
File
objects tocloneDeep
. There is an issue withform-file
where it appears the intention is to clone the object, but when the object is aFile
object, it does not. This occurs at this location:bootstrap-vue/src/components/form-file/form-file.js
Line 373 in19a1727
Because it is not cloned, the
$path
attribute is removed from the originalFile
objects that are put into the model. This makes it impossible to know the full path when a folder is used for drag and drop to this component. This attribute is documented to exist here:https://bootstrap-vue.org/docs/components/form-file#directory-modePR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.).This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: