Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(utils): add file deep cloning#6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cabarnes wants to merge1 commit intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromsmartfile:file-clone-deep

Conversation

cabarnes
Copy link

Describe the PR

Adds cloning ofFile objects tocloneDeep. There is an issue withform-file where it appears the intention is to clone the object, but when the object is aFile object, it does not. This occurs at this location:

flattenDeep(cloneDeep(files)).forEach(file=>{

Because it is not cloned, the$path attribute is removed from the originalFile objects that are put into the model. This makes it impossible to know the full path when a folder is used for drag and drop to this component. This attribute is documented to exist here:https://bootstrap-vue.org/docs/components/form-file#directory-mode

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercelbot commentedJun 16, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/HKRYvEu3kuE8M9GDVZCpNobHr6VX
✅ Preview:https://bootstrap-vue-git-fork-smartfile-file-clone-deep-bootstrap-vue.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit66c66c8:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@cabarnes
Copy link
Author

The Codacy Static Code Analysis seems to be out of sync with the linter in the project. It's wanting the dangling comma butyarn test:lint fails with a requirement to remove the dangling comma

@HiwsHiws requested a review fromjacobmllr95June 16, 2021 21:26
@jacobmllr95jacobmllr95 added PR: PatchRequires patch version bump Type: Fix PR: MinorRequires minor version bump Type: Enhancement and removed PR: PatchRequires patch version bump Type: Fix labelsJun 16, 2021
@codecov
Copy link

codecovbot commentedJun 16, 2021
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base(19a1727) to head(66c66c8).
Report is 214 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@##               dev     #6668   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          299       299             Lines        10258     10260    +2       Branches      2522      2523    +1     =========================================+ Hits         10258     10260    +2
FlagCoverage Δ
unittests100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xanfxanf requested review fromxanf and removed request forjacobmllr95December 19, 2021 14:52
@xanfxanf self-assigned thisDec 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xanfxanfAwaiting requested review from xanf

Assignees

@xanfxanf

Labels
PR: MinorRequires minor version bumpType: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@cabarnes@xanf@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp