Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-table): setaria-sort when usingsortKey andno-local-sorting (closes #6602)#6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedMay 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/3NBZgYvhLerhiEfpFKst3zL65M52 |
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit547840f:
|
codecovbot commentedMay 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6603 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10211 10213 +2 Branches 2521 2522 +1 =========================================+ Hits 10211 10213 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
aria-sort when usingsortKey andno-local-sorting (fixed #6602)aria-sort when usingsortKey andno-local-sorting (fixed #6602)aria-sort when usingsortKey andno-local-sorting (fixed #6602)aria-sort when usingsortKey andno-local-sorting (closes #6602)
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
Fixes an issue where
aria-sortwasn't being correctly set on fields that used asortKeyandno-local-sortingwas set on<b-table>.It should now correctly set them when sorting that column.
Closes#6602.
Working example:https://codesandbox.io/s/bootstrapvue-starter-project-forked-3b7pt?file=/App.vue
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed: