Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
feat(b-modal): add optionaltrigger
parameter to$bvModal.hide()
method#6523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedMar 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/GBcs9EB4bBG6YkK5SiXaMuzGfLac |
trigger
paramater to$bvModal.hide
trigger
parameter to$bvModal.hide
codesandbox-cibot commentedMar 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitd58c113:
|
codecovbot commentedMar 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## dev #6523 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10211 10211 Branches 2521 2522 +1 ========================================= Hits 10211 10211
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trigger
parameter to$bvModal.hide
trigger
parameter to$bvModal.hide()
method
Uh oh!
There was an error while loading.Please reload this page.
Describe the PR
This PR allows for the passing of a trigger, using the
$bvModal.hide
method.This is currently possible via either a
ref
, which can be used to access thehide
method in<b-modal>
, or the samehide
method exposed in various scoped slots of<b-modal>
.I believe this change would allow better flexibility when using the modals on demand.
It might also be worth removing the "protected" prop,
hideFooter: false
, from the following snippet.bootstrap-vue/src/components/modal/helpers/bv-modal.js
Lines 215 to 229 inb2b5c7b
In case users would like to create their own
cancel
andok
buttons while hiding the default ones.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.).This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: