Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(utils/dom): bindrequestAF() towindow (#6508)#6511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedMar 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/8QxmYcWCtGXYqTbzaXA284yeufwp |
codesandbox-cibot commentedMar 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitddc2b46:
|
codecovbot commentedMar 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6511 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10211 10211 Branches 2521 2521 ========================================= Hits 10211 10211
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
requestAF() towindow (#6508)jacobmllr95 commentedMay 4, 2021
@xenolithviktor Can you please confirm that my latest change still provides a working solution for your issue. |
xenolithviktor commentedMay 4, 2021
@jackmu95 I have now tried it with my WebExtension and can confirm that it still works! |
jacobmllr95 commentedMay 4, 2021
Thanks@xenolithviktor! |
Describe the PR
Fixes an issue encountered in WebExtension content scripts. The requestAF function was not properly bound as a method of
window, which is usually fine since the globalthiswould point to window anyways. Howeverthisdoes not point towindowglobally in a content script.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: