Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(b-table): addheader-contextmenu event (closes #5841)#6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dflock wants to merge3 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromphemisystems:table-header-context-click

Conversation

dflock
Copy link
Contributor

@dflockdflock commentedMar 9, 2021
edited by jacobmllr95
Loading

Describe the PR

Adds aheader-contextmenu event, that fires when table headers are context (or right) clicked.

Closes#5841.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercelbot commentedMar 9, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/GfVAzpuz3tUkW2CqEktTXNYXTkqh
✅ Preview:https://bootstrap-vue-git-fork-phemisystems-table-header-contex-54cf23.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedMar 9, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit17017a8:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@jacobmllr95jacobmllr95 changed the titlefeat(b-table): Add header contextmenu event (fixes #5841)feat(b-table): addheader-contextmenu event (closes #5841)May 4, 2021
@jacobmllr95jacobmllr95 self-requested a reviewMay 4, 2021 00:54
@codecov
Copy link

codecovbot commentedMay 6, 2021
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base(27ccc03) to head(17017a8).
Report is 217 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@##               dev     #6488   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          299       299             Lines        10213     10228   +15       Branches      2522      2528    +6     =========================================+ Hits         10213     10228   +15
FlagCoverage Δ
unittests100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solodyagin
Copy link

solodyagin commentedJul 29, 2021
edited
Loading

After applying PR table with property "sticky-header" is not working.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jacobmllr95jacobmllr95Awaiting requested review from jacobmllr95

Assignees
No one assigned
Labels
PR: MinorRequires minor version bumpType: EnhancementType: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table@head-contextmenu event
3 participants
@dflock@solodyagin@jacobmllr95

[8]ページ先頭

©2009-2025 Movatter.jp