Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(b-tabs): add newtabs-before andtabs-after slots#6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Istador wants to merge6 commits intobootstrap-vue:dev
base:dev
Choose a base branch
Loading
fromIstador:new-b-tabs-slots

Conversation

Istador
Copy link
Contributor

Describe the PR

This PR adds two new slots to<b-tabs>, namelytabs-before andtabs-after.

These slots can be used to add content before or after the tabs navigation list.

Usually you'd only want to usetabs-before. Buttabs-after can be used as an alternative, when using bottom placement via theend property.

It's a useful addition when using tabs with the cards integration. Because it allows to add a title to the whole card, that is shown above the navigation tab buttons (example added to theadvanced examples).

In the application that I'm currently working on, I have several cards in a form next to each other that serve as sections with card-titles in the headers. In one of these cards I want to use three tabs. But unlike native cards, the tabs integration doesn't allow to set a title.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) -feat(...), requires a minor version update
  • Enhancement (augments an existing feature) -feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) -fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) -chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to thedev branch,not themaster branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
    • This enhancement PR does not resolve an exising issue afaik.
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
    • It could be broken up intotabs-before andtabs-after individually, but it's a small change and they kind of belong together.
  • The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
    • Not needed, because the slots aren't part of the type declarations.
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
    • The percentage has increased a bit, but that's not due to the tests added.
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)
    • Not needed for this kind of change.

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercelbot commentedMar 8, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/CtK7qbfRcfuuZEfBtbTj2guBJRgf
✅ Preview:https://bootstrap-vue-git-fork-istador-new-b-tabs-slots-bootstrap-vue.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedMar 8, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit21252ca:

SandboxSource
BootstrapVue Starter ProjectConfiguration
BootstrapVue Nuxt.js Starter ProjectConfiguration

@codecov
Copy link

codecovbot commentedMar 8, 2021
edited
Loading

Codecov Report

Merging#6487 (21252ca) intodev (ccf62a4) willnot change coverage.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff            @@##               dev     #6487   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          299       299             Lines        10265     10269    +4       Branches      2527      2529    +2     =========================================+ Hits         10265     10269    +4
FlagCoverage Δ
unittests100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
src/components/tabs/tabs.js100.00% <100.00%> (ø)
src/constants/slots.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateccf62a4...21252ca. Read thecomment docs.

@jacobmllr95jacobmllr95 changed the titlefeat(b-tabs): add new slots tabs-before and tabs-afterfeat(b-tabs): add newtabs-before andtabs-after slotsMay 4, 2021
@jacobmllr95jacobmllr95 self-requested a reviewMay 4, 2021 01:00
@jacobmllr95jacobmllr95 added PR: MinorRequires minor version bump Type: Feature labelsMay 4, 2021
@vercel
Copy link

vercelbot commentedMay 4, 2021

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jacobmllr95jacobmllr95Awaiting requested review from jacobmllr95

Assignees
No one assigned
Labels
PR: MinorRequires minor version bumpType: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Istador@jacobmllr95@xanf

[8]ページ先頭

©2009-2025 Movatter.jp