Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
feat(b-tabs): add newtabs-before
andtabs-after
slots#6487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedMar 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/CtK7qbfRcfuuZEfBtbTj2guBJRgf |
codesandbox-cibot commentedMar 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit21252ca:
|
codecovbot commentedMar 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6487 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10265 10269 +4 Branches 2527 2529 +2 =========================================+ Hits 10265 10269 +4
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
tabs-before
andtabs-after
slotsDeployment failed with the following error:
|
Describe the PR
This PR adds two new slots to
<b-tabs>
, namelytabs-before
andtabs-after
.These slots can be used to add content before or after the tabs navigation list.
Usually you'd only want to use
tabs-before
. Buttabs-after
can be used as an alternative, when using bottom placement via theend
property.It's a useful addition when using tabs with the cards integration. Because it allows to add a title to the whole card, that is shown above the navigation tab buttons (example added to the
advanced examples
).In the application that I'm currently working on, I have several cards in a form next to each other that serve as sections with card-titles in the headers. In one of these cards I want to use three tabs. But unlike native cards, the tabs integration doesn't allow to set a title.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch,not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)tabs-before
andtabs-after
individually, but it's a small change and they kind of belong together.fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.).This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
updatedtests are included and passing (required for new features and enhancements)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: