NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.5k

fix(b-modal): check for wether the body is overflowing#6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

wparad wants to merge3 commits intobootstrap-vue:dev

base:dev

Choose a base branch

fromwparad:patch-1

Open

fix(b-modal): check for wether the body is overflowing#6481

wparad wants to merge3 commits intobootstrap-vue:devfromwparad:patch-1

Conversation

Copy link

wparad commentedMar 5, 2021•
edited
Loading

Describe the PR

Opening a modal incorrectly always pads the body and the modal even when there is no reason to because the scroll bar isn't needed.

PR checklist

What kind of change does this PR introduce? (check at least one)

Bugfix (fixes a boo-boo in the code) -fix(...), requires a patch version update

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

It's submitted to thedev branch,not themaster branch
When resolving a specific issue, it's referenced in the PR's title (i.e.[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
The title should follow theConventional Commits naming convention (i.e.fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOG is generated from these messages, and determines the next version type (patch or minor).

Copy link

vercelbot commentedMar 5, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/JJQjoXFq6CD7A6rKTf7hKwRe3Mnv
✅ Preview:https://bootstrap-vue-git-fork-wparad-patch-1-bootstrap-vue.vercel.app

vercelbottemporarily deployed to Preview

March 5, 2021 16:30

Inactive

Copy link

codesandbox-cibot commentedMar 5, 2021•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit7261b13:

Sandbox	Source
BootstrapVue Starter Project	Configuration
BootstrapVue Nuxt.js Starter Project	Configuration

Copy link

codecovbot commentedMar 5, 2021•
edited
Loading

Codecov Report

Merging#6481 (7261b13) intodev (f8caaec) willdecrease coverage by0.06%.
The diff coverage is75.00%.

@@             Coverage Diff             @@##               dev    #6481      +/-   ##===========================================- Coverage   100.00%   99.93%   -0.07%===========================================  Files          299      299                Lines        10211    10213       +2       Branches      2521     2523       +2     ===========================================- Hits         10211    10206       -5- Misses           0        5       +5- Partials         0        2       +2

Flag	Coverage Δ
unittests	`99.93% <75.00%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
src/components/modal/helpers/modal-manager.js	`92.39% <75.00%> (-7.61%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef8caaec...7261b13. Read thecomment docs.

wparad changed the title~~Fix check for isBodyOverflowing~~Fix(alert) check for isBodyOverflowing

Mar 5, 2021

wparad changed the title~~Fix(alert) check for isBodyOverflowing~~Fix(modal) check for isBodyOverflowing

Mar 5, 2021

wparad changed the title~~Fix(modal) check for isBodyOverflowing~~Fix(modal) calculate check for isBodyOverflowing correctly

Mar 5, 2021

Copy link

Member

Hiws commentedMar 5, 2021•
edited
Loading

I believe the current behavior is intended.
To avoid having page shift in the background when opening/closing a modal.

Here's how it currently looks on the docs when opening a modal:

KSZdp1jiGW.mp4

Notice how the added padding makes it so the background doesn't shift.

Compared to the docs with your change applied:

NPK5cxxLIN.mp4

Copy link

Author

wparad commentedMar 5, 2021•
edited
Loading

I see, but then you have the opposite problem if the screen doesn't have a scrollbar, and the content is not as wide as the screen. What's the fix then?

Copy link

Member

Hiws commentedMar 5, 2021

I see, but then you have the opposite problem if the screen doesn't have a scrollbar, and the content is not as wide as the screen. What's the fix then?

I'm not quite sure what you mean.
No padding should be applied if there's no scrollbar on the page.

ux9auwXBIE.mp4