Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-table): defaultrole togrid whenselectable andtable otherwise#6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…into ag/table-role
vercelbot commentedJan 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/bxhpqivan |
codesandbox-cibot commentedJan 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit83cf46c:
|
codecovbot commentedJan 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6383 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10141 10142 +1 Branches 2524 2522 -2 =========================================+ Hits 10141 10142 +1
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
role togrid whenselectable andtable otherwiserole togrid whenselectable andtable otherwiserole togrid whenselectable andtable otherwisejacobmllr95 commentedJan 31, 2021
Thanks@andrei-gheorghiu! |
Describe the PR
Resulting
<table>of<b-v-table>should have a defaultroleoftable.If
selectableistrue, theroleapplied should begrid.In both cases, user-provided role has priority.
Related:#6305
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: