Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
fix(b-link): remove default values fromvue-router pass-down props (closes #6373)#6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedJan 28, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/bootstrap-vue/bootstrap-vue/jz0exlhx7 |
codesandbox-cibot commentedJan 28, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit2e758af:
|
codecovbot commentedJan 28, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #6374 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 299 299 Lines 10108 10110 +2 Branches 2510 2512 +2 =========================================+ Hits 10108 10110 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
DerKleineGauss commentedJan 28, 2021
thank you very much :) |
samturrell commentedNov 2, 2021
@jacobmllr95 this fix doesn't appear to be in the latest tagged release? |
DerKleineGauss commentedNov 3, 2021
I am still facing this problem with updated version, too |
Describe the PR
This PR removes the default values from props that are passed down to
<router-link>to avoid deprecation warnings.Ref:https://next.router.vuejs.org/guide/migration/#removal-of-event-and-tag-props-in-router-link
Closes#6373.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch,not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc.).This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: