Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Text colour of Disabled tab could be lighter.#6184

emfluenceindia started this conversation inIdeas
Discussion options

Can we make the default text colour ofDisabled Tab bit more lighter?
Currently this ispretty close to that of Active Tab's text colour.

Here is the screenshot from thedocumentation page

image

You must be logged in to vote

Replies: 3 comments 10 replies

Comment options

Hiws
Dec 14, 2020
Maintainer

You're probably right, but this is more of an upstream issue.
So i would suggest you open up an issue on theBootstrap Repo, with your suggestion.

You can also modify the color in your project easily if you're using SCSS.
The following variable$nav-link-disabled-color, can be edited to change the disabled color, just be aware<b-nav> and<b-tabs> share the same styling.

(also glad to see people are using the new Discussions Section)

You must be logged in to vote
2 replies
@emfluenceindia
Comment options

Thanks a lot for your reply. I would love to open an issue and contribute.

I have actually downloaded from the project Github repo at my local but cannot run it. The contribution doc says I need yarn which I don't have. I however, have npm. How can I run the dev server and run the project using npm? Please help.

@Hiws
Comment options

HiwsDec 14, 2020
Maintainer

Which repo do you refer to? Bootstrap or BootstrapVue?

Comment options

Bootstrapvue. This one:https://github.com/bootstrap-vue/bootstrap-vue.
I am followinghttps://github.com/bootstrap-vue/bootstrap-vue/blob/dev/CONTRIBUTING.md

You must be logged in to vote
1 reply
@Hiws
Comment options

HiwsDec 14, 2020
Maintainer

Whilenpm isn't recommended to use, it's still possible.
After cloning the repo, you should be able to runnpm install in the cloned folder and thennpm run docs-dev to launch the docs locally.
You can then uselocalhost:3000/play to play around with changes locally.

But i do recommend you to install yarn, there isn't much difference syntax wise to NPM, and some scripts are based around them.
It's also a good thing to learn as it's widely used.

Comment options

Thanks again!
npm run docs-dev has started the dev server!!

In fact I want to use Yarn as well, but wondering whether installing Yarn globally could have any conflict with npm since it has been installed globally as well. I Googled but could not get a suitable answer to it.

You must be logged in to vote
7 replies
@Hiws
Comment options

HiwsDec 14, 2020
Maintainer

These variables are defined in Bootstraps_variables.scss file, which contains all the variables (with default values) that they use in their project. You can see this filehere.
Be aware thatBootstrapVue only supportsBootstrap v4 right now, and that the mainBootstrap branch is for v5.
So if you go looking, remember to go on the v4-dev branch, or the latest v4 tag when viewing theBootstrap repo.

BootstrapVue has some custom SCSS variables, which are contained in it's own_variables files. You can view this filehere.

@Hiws
Comment options

HiwsDec 14, 2020
Maintainer

Just be aware that the specific variable$nav-link-disabled-color, that I mentioned is from theBootstrap repo and notBootstrapVue, that you're currently looking at.
So if you want the default value changed, you should not submit a PR toBootstrapVue, but insteadBootstrap, as we getmost of the CSS from them. (hence the name).

@emfluenceindia
Comment options

If I have understood correctly, if I want this colour to change, I need to work on Bootstrap v4 repo and submit a PR there. If it is accepted, BootstrapVue will automatically be updated as well since it is fetching these variables directly from Bootstrap?

Becausehttps://github.com/twbs/bootstrap/blob/v4.5.2/scss/_variables.scss has$nav-link-disabled-color which is using$gray-600 which is actually$gray-600: #6c757d !default; in the same file.

@Hiws
Comment options

HiwsDec 14, 2020
Maintainer

If I have understood correctly, if I want this colour to change, I need to work on Bootstrap v4 repo and submit a PR there. If it is accepted, BootstrapVue will automatically be updated as well since it is fetching these variables directly from Bootstrap?

Basically, yes.

However, SCSS allows you to change it freely in your own project without submitting any PRs to Bootstrap.
You can change all the variables you want in your own project. Bootstrap simply supplies some default values that can be changed by the developer in their own projects.

You can read more info on the docs on how to use SCSS in your own project:
Setup:https://bootstrap-vue.org/docs#using-module-bundlers
Theming:https://bootstrap-vue.org/docs/reference/theming

Additional info on theming:https://getbootstrap.com/docs/4.5/getting-started/theming/

@emfluenceindia
Comment options

Thank you for you help! I have created a feature request at Bootstraphere

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Category
Ideas
Labels
None yet
2 participants
@emfluenceindia@Hiws

[8]ページ先頭

©2009-2025 Movatter.jp