Optimize NanBoxedValue::clone by inlining the calls toas_object/string/symbol/bigint.
Optimize NanBoxedValue::tag_pointer by receiving aNonNull pointer, which removes the assertion we have there. Also marks the rarest path (unsupported platform) as a cold function.
Optimize GcHeader::inc_ref_count by marking the possible ref count overflow as a cold path.

Main results

RESULT Richards 237
RESULT DeltaBlue 243
RESULT Crypto 192
RESULT RayTrace 524
RESULT EarleyBoyer 618
RESULT RegExp 87.6
RESULT Splay 877
RESULT NavierStokes 427
SCORE 323

PR results

RESULT Richards 229
RESULT DeltaBlue 238
RESULT Crypto 197
RESULT RayTrace 532
RESULT EarleyBoyer 635
RESULT RegExp 91.8
RESULT Splay 888
RESULT NavierStokes 439
SCORE 327

jedel1043 added5 commits

October 27, 2025 17:02

optimize NanBoxedValue::clone

82e02ed

optimize NanBoxedValue::tag_pointer

f9b3408

optimize GcHeader::inc_ref_count

9094d75

add comments about optimizations

ea60b58

change panic message

9861b1e

jedel1043 added the InternalCategory for changelog label

Oct 27, 2025

jedel1043 requested a review froma team

October 27, 2025 23:16

jedel1043 added this to thenext-release milestone

Oct 27, 2025

Copy link

github-actionsbot commentedOct 27, 2025•
edited
Loading

Test262 conformance changes

Test result	main count	PR count	difference
Total	50,595	50,595	0
Passed	47,656	47,656	0
Ignored	2,036	2,036	0
Failed	903	903	0
Panics	0	0	0
Conformance	94.19%	94.19%	0.00%

jedel1043 added4 commits

October 27, 2025 17:28

remove assert_unchecked

092ff1e

cargo clippy

c9ab41c

fix test

8795234

change panic msg

976206c

Copy link

codecovbot commentedOct 28, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is75.00000% with7 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.18%. Comparing base (6ddc2b4) to head (976206c).
⚠️ Report is 577 commits behind head on main.

Files with missing lines	Patch %	Lines
core/engine/src/value/inner/nan_boxed.rs	80.00%	4 Missing⚠️
core/gc/src/internals/gc_header.rs	50.00%	3 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main    #4506      +/-   ##==========================================+ Coverage   47.24%   57.18%   +9.93%==========================================  Files         476      503      +27       Lines       46892    57401   +10509     ==========================================+ Hits        22154    32824   +10670+ Misses      24738    24577     -161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nekevss approved these changes

Oct 29, 2025

View reviewed changes

Copy link

Member

nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

nekevss added this pull request to themerge queue

Oct 29, 2025

github-merge-queuebot removed this pull request from themerge queue due to failed status checks

Oct 29, 2025

jedel1043 added this pull request to themerge queue

Oct 29, 2025

Merged via the queue intoboa-dev:main with commit1088cc4

Oct 29, 2025

16 checks passed

jedel1043 deleted the optimize-nan-boxed branch

October 29, 2025 04:19

Labels

Internal

Category for changelog

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Optimize`NanBoxedValue` related operations#4506

Optimize`NanBoxedValue` related operations#4506

Uh oh!

Conversation

jedel1043 commentedOct 27, 2025•
edited
Loading