Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Regex Improvements#4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jasonwilliams wants to merge6 commits intoboa-dev:main
base:main
Choose a base branch
Loading
fromjasonwilliams:regex_improvements

Conversation

@jasonwilliams
Copy link
Member

@jasonwilliamsjasonwilliams commentedJun 27, 2025•
edited
Loading

  • inline the take_while_ascii_pred function
  • change flag handling to stack allocation by using a fixed sized array
  • Parse regex literals at an earlier opportunity when inspecting expressions (to reduce stack depth)

- inline the take_while_ascii_pred function- change flag handling to stack allocation by using a fixed sized array- Parse regex literals at an earlier opportunity when inspecting expressions
@codecov
Copy link

codecovbot commentedJul 8, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is62.16216% with14 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base(6ddc2b4) to head(1cb09f4).
Report is 460 commits behind head on main.

Files with missing linesPatch %Lines
core/parser/src/lexer/regex.rs71.42%8 Missing⚠️
core/parser/src/lexer/cursor.rs33.33%6 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #4310      +/-   ##==========================================+ Coverage   47.24%   50.31%   +3.07%==========================================  Files         476      498      +22       Lines       46892    49924    +3032     ==========================================+ Hits        22154    25120    +2966- Misses      24738    24804      +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasonwilliamsjasonwilliams added the run-benchmarkLabel used to run banchmarks on PRs labelJul 8, 2025
@jasonwilliamsjasonwilliams removed the run-benchmarkLabel used to run banchmarks on PRs labelJul 8, 2025
@AdithyaLaakso
Copy link

I took your suggestion in the issues and made a new function for this issue using an arrayvec which I believe will be marginally more memory efficient in the vast majority of cases (where no flags are given) than allocating an array. Additionally, I added error handling for the case where more than 8 regex flags are added and preserved the original version of the function for future use.

However, your pull request covers a lot of area that mine does not we should merge them!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonwilliams@AdithyaLaakso
[8]ページ先頭
©2009-2025 Movatter.jp