Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Eric Andrade#301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
buddhaplex wants to merge3 commits intobloominstituteoftechnology:master
base:master
Choose a base branch
Loading
frombuddhaplex:master

Conversation

@buddhaplex
Copy link

No description provided.

@justinborek
Copy link

justinborek commentedMar 21, 2018
edited
Loading

What Went Well:

Good work on this one, and welcome to JS land! You were able to complete the tasks, and your code looks pretty good for the most part. Nice commit messages and frequency as well. You're grasping the material, just keep pushing yourself!

Areas For Improvement:

Make sure you're always using camelCase and choosing descriptive variable names. Inarrays.js you create the variablefiltrue in thefilter method. If using that name, you would want to usefilTrue but a possible better option would just befiltered. It would be a little more descriptive to the next person to read the code. Also, your filter method was super close! You wrote:

const filtrue = [];  for (let i = 0; i < elements.length; i++) {    if (cb(elements[i]) === true) {      return filtrue.push(elements[i]);    }    return filtrue;  }// ---------- Solutionconst filtrue = [];  for (let i = 0; i < elements.length; i++) {    if (cb(elements[i]) === true) {      filtrue.push(elements[i]);    }  }  return filtrue;};```#### Remember that in this case you don't need to return out of the `if` statement since you're changing a variable, and that your `return` should be outside the loop, since with filter you're only doing one return. That simple change would pass the final test.## Questions: #### None, keep it up!## Rating (1-3)#### 2

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buddhaplex@justinborek

[8]ページ先頭

©2009-2025 Movatter.jp