- Notifications
You must be signed in to change notification settings - Fork1
Robustify R setting detection#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bnaras wants to merge24 commits intomainChoose a base branch fromcran_fix
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
24 commits Select commitHold shift + click to select a range
437b2e2
Robustify R setting detection
bnarasb040f7f
Update build.rs
bnaras0e1daf8
Update test.yml
bnaras7701cf3
Update test.yml
bnarasfdf3e7b
Update test.yml
bnarascc1dd30
Update test.yml
bnaras71472df
Update test.yml
bnarasae0ebae
Update test.yml
bnaras595f66b
Update test.yml
bnaras48b2c00
Update test.yml
bnaras26a75ce
Update test.yml
bnaras34bbb1e
Update test.yml
bnaraseccb0b0
Update test.yml
bnaraseebc441
Update test.yml
bnarasa2772a3
Update test.yml
bnaras1d7a5c8
Update test.yml
bnaras95ca555
Update test.yml
bnarasbff715c
Update test.yml
bnaras78482a8
Update test.yml
bnaras79a0a9f
Switched back to ci-cargo for workflow
bnaras43aea76
Try a new test
bnarasfee6419
Update Cargo.toml
bnaras466a91f
Update shlex use
bnaras32217d5
Update actions
bnarasFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions.github/workflows/newtest.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
name: cargo-test-on-r-platforms | ||
on: | ||
push: | ||
branches: [main, master] | ||
pull_request: | ||
workflow_dispatch: | ||
jobs: | ||
cargo-test: | ||
runs-on: ${{ matrix.config.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
config: | ||
# -------- OS / Rust target triple ----------------- | ||
- {os: ubuntu-latest, rust: 'stable'} | ||
- {os: macos-latest, rust: 'stable'} | ||
- {os: windows-latest, rust: 'stable-x86_64-pc-windows-gnu'} | ||
env: | ||
CARGO_TERM_COLOR: always | ||
steps: | ||
#------------------------------------------------------ | ||
# 1. Check out your repository | ||
#------------------------------------------------------ | ||
- uses: actions/checkout@v4 | ||
#------------------------------------------------------ | ||
# 2. Install the same R binaries CRAN uses for R-CMD-check | ||
# (needed only for BLAS/LAPACK and R_HOME detection) | ||
#------------------------------------------------------ | ||
- uses: r-lib/actions/setup-r@v2 | ||
with: | ||
r-version: 'release' | ||
#------------------------------------------------------ | ||
# 3. Install Rust | ||
# * On Windows we pick the GNU target so the linker | ||
# understands R's libRblas.dll.a / libRlapack.dll.a | ||
#------------------------------------------------------ | ||
- uses: actions-rs/toolchain@v1 | ||
with: | ||
profile: minimal | ||
toolchain: ${{ matrix.config.rust }} | ||
override: true | ||
components: rustfmt | ||
#------------------------------------------------------ | ||
# 4. Windows-only: expose R’s DLLs at run-time | ||
#------------------------------------------------------ | ||
- name: Add R BLAS/LAPACK directory to PATH (Windows) | ||
if: runner.os == 'Windows' | ||
run: | | ||
echo "$Env:R_HOME\\bin\\x64" | Out-File -FilePath $Env:GITHUB_PATH -Encoding utf8 -Append | ||
#------------------------------------------------------ | ||
# 5. Build once in release mode (catches link problems) | ||
#------------------------------------------------------ | ||
- name: cargo build | ||
run: cargo build --release --verbose | ||
#------------------------------------------------------ | ||
# 6. Run the full test suite in release mode | ||
#------------------------------------------------------ | ||
- name: cargo test | ||
run: cargo test --all --release --verbose |
275 changes: 88 additions & 187 deletions.github/workflows/test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletionsCHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.