❌Finding 1 continued: This fetch command should have error handling. If it fails, the script will continue with a stale or non-existent localmain branch.

Suggestion:

if! git fetch origin main:main;thenecho"ERROR: Failed to fetch main branch"exit 1fi

⚠️Missing error handling: Ifgit fetch fails, the script continues with potentially stale or missing data, leading to incorrect validation results.

♻️Finding 4 - Cleanup: Consider adding cleanup for temporary files at the end of the script:

rm -f /tmp/main_migrations.txt /tmp/current_migrations.txt

❌Finding 1 - Format enforcement issue: This regex requires leading zeros ([0-9]{2} for month and day), but the repository already contains at least one migration that violates this:

2025-10-3_00_AddOrganizationIntegration_ReadByTeamsConfigurationTenantIdTeamIdStoredProcedure.sql

This will cause validation failures on PRs that rebase against main if the problematic migration gets included.

Options:

1. Rename existing non-compliant migrations before merging this PR (preferred for consistency)
2. Make regex more permissive:^[0-9]{4}-[0-9]{1,2}-[0-9]{1,2}_[0-9]{2}_.+\.sql$

❌Critical: Regex allows non-compliant migration that breaks sorting

The repository contains2025-10-3_00_AddOrganizationIntegration_ReadByTeamsConfigurationTenantIdTeamIdStoredProcedure.sql (note:10-3 not10-03).

Problem: Lexicographic string comparison produces incorrect ordering:

• "2025-10-3" sortsAFTER"2025-10-30" in ASCII comparison
• At character position 9:'3' (from"10-3_") vs'0' (from"10-30")
• Character'3' has higher ASCII value than'0', so"10-3" >"10-30"

Impact:

• New migrations dated 2025-10-30 through 2025-11-03 will incorrectly fail validation
• Chronological order is violated in the migration list
• Sorting doesn't reflect actual date order

Fix required before merging: Rename the non-compliant migration:

git mv util/Migrator/DbScripts/2025-10-3_00_AddOrganizationIntegration_ReadByTeamsConfigurationTenantIdTeamIdStoredProcedure.sql \     util/Migrator/DbScripts/2025-10-03_00_AddOrganizationIntegration_ReadByTeamsConfigurationTenantIdTeamIdStoredProcedure.sql

Then restore strict regex validation:

👏 Also a nice improvement here.

💭Finding 5 - Multiple new migrations: When a PR adds multiple migrations (e.g.,2025-11-27_00_A.sql and2025-11-26_00_B.sql), this only validates each againstLAST_MAIN_MIGRATION, not against each other.

The out-of-order new migrations would be caught (B would fail since it's < A alphabetically), but the error message might be confusing since it references the main branch rather than the other new migration.

Is this the intended behavior, or should we also validate ordering within the set of new migrations?

🎨Finding 6 - Enhanced error message: Consider adding the specific git command to help developers fix the issue:

echo"To fix this issue:"echo"  1. Rename using git:"echo"     git mv util/Migrator/DbScripts/$MIGRATION_NAME util/Migrator/DbScripts/YYYY-MM-DD_NN_NewName.sql"echo"  2. Choose a date after$LAST_MAIN_MIGRATION"echo"  3. Commit the change: git commit -m 'Rename migration to fix ordering'"

🎨Enhancement: Add specific git commands to help developers fix issues:

I assume these 2 jobs are identical except for the source of the current migrations? I suggest that the comparison logic could be moved into a script for reuse, e.g.

// job-specific logic to get the migrations and write them to temp files// then run the comparison/validationsh verify-migrations.sh /tmp/prev_migrations.txt /tmp/current_migrations.txt