Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdefa441

Browse files
janezdmarkotoplak
authored andcommitted
pylint
1 parent9b335a6 commitdefa441

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

‎Orange/widgets/data/owfile.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
QStyle,QComboBox,QMessageBox,QGridLayout,QLabel, \
1010
QLineEdit,QSizePolicyasPolicy,QCompleter
1111
fromAnyQt.QtCoreimportQt,QTimer,QSize,QUrl
12-
fromAnyQt.QtGuiimportQBrush
1312

1413
fromorangewidget.utils.filedialogsimportformat_filter
1514
fromorangewidget.workflow.drophandlerimportSingleUrlDropHandler
@@ -327,6 +326,7 @@ def select_file(self, n):
327326
self.set_file_list()
328327

329328
defselect_sheet(self):
329+
# pylint: disable=unsubscriptable-object
330330
self.recent_paths[0].sheet=self.sheet_combo.currentText()
331331
self.load_data()
332332

@@ -339,7 +339,7 @@ def select_reader(self, n):
339339
return# ignore for URL's
340340

341341
ifself.recent_paths:
342-
path=self.recent_paths[0]
342+
path=self.recent_paths[0]# pylint: disable=unsubscriptable-object
343343
ifn==0:# default
344344
path.file_format=None
345345
elifn<=len(self.available_readers):
@@ -384,6 +384,7 @@ def browse_file(self, in_demos=False):
384384
return
385385
self.add_path(filename)
386386
ifreaderisnotNone:
387+
# pylint: disable=unsubscriptable-object
387388
self.recent_paths[0].file_format=reader.qualified_name()
388389

389390
self.source=self.LOCAL_FILE
@@ -479,6 +480,7 @@ def _get_reader(self) -> FileFormat:
479480
path=self.last_path()
480481
self.reader_combo.setEnabled(True)
481482

483+
# pylint: disable=unsubscriptable-object
482484
ifself.recent_pathsandself.recent_paths[0].file_format:
483485
qname=self.recent_paths[0].file_format
484486
qname_index= {r.qualified_name():ifori,rinenumerate(self.available_readers)}
@@ -508,6 +510,7 @@ def _get_reader(self) -> FileFormat:
508510
self.select_reader(old_idx)
509511
returnself._get_reader()
510512

513+
# pylint: disable=unsubscriptable-object
511514
ifself.recent_pathsandself.recent_paths[0].sheet:
512515
reader.select_sheet(self.recent_paths[0].sheet)
513516
returnreader
@@ -597,10 +600,12 @@ def _describe(table):
597600
returntext
598601

599602
defstoreSpecificSettings(self):
603+
# pylint: disable=unsubscriptable-object
600604
self.current_context.modified_variables=self.variables[:]
601605

602606
defretrieveSpecificSettings(self):
603607
ifhasattr(self.current_context,"modified_variables"):
608+
# pylint: disable=unsubscriptable-object
604609
self.variables[:]=self.current_context.modified_variables
605610

606611
defreset_domain_edit(self):

‎Orange/widgets/data/tests/test_owfile.py‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# Test methods with long descriptive names can omit docstrings
22
# pylint: disable=missing-docstring,protected-access,too-many-public-methods
3-
importos
43
fromosimportpath,remove,getcwd
54
fromos.pathimportdirname
65
importunittest
@@ -24,7 +23,7 @@
2423
Domain,DiscreteVariable,ContinuousVariable
2524
fromOrange.utilimportOrangeDeprecationWarning
2625

27-
fromOrange.data.ioimportTabReader,XlsReader
26+
fromOrange.data.ioimportTabReader
2827
fromOrange.testsimportnamed_file
2928
fromOrange.widgets.data.owfileimportOWFile,OWFileDropHandler,DEFAULT_READER_TEXT
3029
fromOrange.widgets.utils.filedialogsimportdialog_formats,format_filter,RecentPath
@@ -42,7 +41,9 @@ class FailedSheetsFormat(FileFormat):
4241
defread(self):
4342
pass
4443

44+
@property
4545
defsheets(self):
46+
# pylint: disable=broad-exception-raised
4647
raiseException("Not working")
4748

4849

@@ -138,6 +139,7 @@ def _drop_event(self, url):
138139
deftest_check_file_size(self):
139140
self.assertFalse(self.widget.Warning.file_too_big.is_shown())
140141
self.widget.SIZE_LIMIT=4000
142+
# We're avoiding __new__, pylint: disable=unnecessary-dunder-call
141143
self.widget.__init__()
142144
self.assertTrue(self.widget.Warning.file_too_big.is_shown())
143145

@@ -338,7 +340,9 @@ def test_check_datetime_disabled(self):
338340
withnamed_file(dat,suffix=".tab")asfilename:
339341
self.open_dataset(filename)
340342
domain_editor=self.widget.domain_editor
341-
idx=lambdax:self.widget.domain_editor.model().createIndex(x,1)
343+
344+
defidx(x):
345+
returnself.widget.domain_editor.model().createIndex(x,1)
342346

343347
qcombobox=QComboBox()
344348
combo=ComboDelegate(domain_editor,
@@ -466,7 +470,7 @@ def test_select_reader(self):
466470

467471
deftest_auto_detect_and_override(self):
468472
tab_as_xlsx=FileFormat.locate("actually-a-tab-file.xlsx",
469-
os.path.split(__file__)[0])
473+
path.split(__file__)[0])
470474
iris=FileFormat.locate("iris",dataset_dirs)
471475

472476
reader_combo=self.widget.reader_combo

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp