NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commitaadc61d

committed

bugsymfony#3707 make method supportsClass() in custom voter compatible with the interface's documentation (xabbuh)

This PR was merged into the 2.3 branch.Discussion----------make method supportsClass() in custom voter compatible with the interface's documentation| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |symfony#3702Commits-------36384db make method supportsClass() in custom voter compatible with the interface's documentation

2 parents5035837 +36384db commitaadc61dCopy full SHA for aadc61d

File tree

1 file changed

-4

lines changed

cookbook/security
- voters_data_permission.rst

1 file changed

-4

lines changed

`‎cookbook/security/voters_data_permission.rst‎`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,6 @@ edit a particular object. Here's an example implementation::`
`64`	`64`	`use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;`
`65`	`65`	`use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;`
`66`	`66`	`use Symfony\Component\Security\Core\User\UserInterface;`
`67`		`- use Acme\DemoBundle\Entity\Post;`
`68`	`67`
`69`	`68`	`class PostVoter implements VoterInterface`
`70`	`69`	`{`
`@@ -79,9 +78,11 @@ edit a particular object. Here's an example implementation::`
`79`	`78`	`));`
`80`	`79`	`}`
`81`	`80`
`82`		`- public function supportsClass($obj)`
	`81`	`+ public function supportsClass($class)`
`83`	`82`	`{`
`84`		`- return $obj instanceof Post;`
	`83`	`+ $supportedClass = 'Acme\DemoBundle\Entity\Post';`
	`84`	`+`
	`85`	`+ return $supportedClass === $class \|\| is_subclass_of($class, $supportedClass);`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`/**`
`@@ -90,7 +91,7 @@ edit a particular object. Here's an example implementation::`
`90`	`91`	`public function vote(TokenInterface $token, $post, array $attributes)`
`91`	`92`	`{`
`92`	`93`	`// check if class of this object is supported by this voter`
`93`		`- if (!$this->supportsClass($post)) {`
	`94`	`+ if (!$this->supportsClass(get_class($post))) {`
`94`	`95`	`return VoterInterface::ACCESS_ABSTAIN;`
`95`	`96`	`}`
`96`	`97`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaadc61d

File tree

1 file changed

1 file changed

`‎cookbook/security/voters_data_permission.rst‎`

0 commit comments