Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fit b spline se3#129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
myeatman-bdai wants to merge6 commits intomaster
base:master
Choose a base branch
Loading
fromfit-b-spline-SE3
Draft

Fit b spline se3#129

myeatman-bdai wants to merge6 commits intomasterfromfit-b-spline-SE3

Conversation

myeatman-bdai
Copy link
Collaborator

Add functionality to fit a cubic-SE3-B-spline to data.

@myeatman-bdai
Copy link
CollaboratorAuthor

Converted to draft because this uses scipy functionality not available in the version associated with the dependency list for 3.7 python.

@jcao-bdaijcao-bdai removed their request for reviewDecember 11, 2024 15:16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure why this is needed. You would change the code pattern from:

x = SO3(R1)x = SO3(R2)

to

x = SO3(R1)x.R = R2

It's no shorter, clearer, or cheaper. The second line has a hiddenSO3 constructor and like the first option leaves an object to be garbage collected. It also makes the check for matrix validity happen, which is in principle a good thing, but is expensive. If an SMTB module knows that the matrix belongs to SO(3) then that check can be circumvented by

x = SO3(R1, check=False)x = SO3(R2, check=False)

This is a "feature" user's can also use but at their own peril. In your interpolator you know that the matrix you compute is in SO(3).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Given the usefulness of the functionality, and their independence from the rest of the code, nothing in SMTB depends on these, the risk is low, and should be added. But see comments below.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are a really useful addition. The control poses

    def __init__(         self,         control_poses: List[SE3],     ) -> None:

are passed as a list ofSE3s not as a multi-elementSE3. What's the thinking there?

There are multiple interpolator classes, each algorithm specific. Would it be better to have one interpolator class with a passed argument to say which one is used. This is kind of the approach that SciPy takes with optimisers and integrators that have amethod parameter. Simplest approach would be a wrapper class that instantiates one of the specific classes, all of them with a common parent class.

@petercorke
Copy link
Collaborator

@myeatman-bdai a few more thoughts on this PR:

  • be great to have some more user level documentation andrunblock examples, and also to integrate it into the ReST documentation, I can't find the current spline classes by search or table of contents. I'm happy to help out here, but probably need a bit more to go on than what's there (actually the unit tests might be a start for me)
  • there's a kinematic/dynamic constrained trajectory generatorTOPPRA that might be useful to import, wrap or just play nicely with. I've not used it.

@petercorke
Copy link
Collaborator

Converted to draft because this uses scipy functionality not available in the version associated with the dependency list for 3.7 python.

Not sure we should be held back by Python 3.7, it's well past EOL.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@petercorkepetercorkepetercorke left review comments

@bokorn-bdaiibokorn-bdaiiAwaiting requested review from bokorn-bdaii

@amessing-bdaiamessing-bdaiAwaiting requested review from amessing-bdai

@jhavljhavlAwaiting requested review from jhavljhavl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@myeatman-bdai@petercorke

[8]ページ先頭

©2009-2025 Movatter.jp