- Notifications
You must be signed in to change notification settings - Fork13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Adds support for Fn Project#43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bbilger requested changesNov 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@mjg123,
Awesome work! Thanks for your contribution.
Three things, though:
- The pull request does not build against master. The problem is that I am currently updating JRestless to work with Jersey 2.26 which introduced a few breaking changes:https://jersey.github.io/documentation/latest/user-guide.html#mig-2.26-injection-manager See:94aee46
- Is it possible to use slf4j instead of writing to stderr, directly?
- What's the license of the code? Apache 2.0?
| protected WrappedOutput onRequestFailure(Exception e, | ||
| WrappedInput wrappedInput, | ||
| @Nullable JRestlessContainerRequest jRestlessContainerRequest) { | ||
| System.err.println("request failed" + e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can this be logged via slf4j?
Thanks for your quick attention! I'll get an update up today or tomorrow. |
Some breaking changes in this version of Jersey. Also sends a System.err.println via slf4j
bbilger approved these changesNov 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to use JRestless to support running JAX-RS apps on Fn Projects
See Fn Project at: http//fnproject.io
See blog at:http://mjg123.github.io/2017/11/08/Jax-RS-on-Fn.html
See example project at:https://github.com/fnproject/fn-jrestless-example