- Notifications
You must be signed in to change notification settings - Fork13
Adds support for Fn Project#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@mjg123,
Awesome work! Thanks for your contribution.
Three things, though:
- The pull request does not build against master. The problem is that I am currently updating JRestless to work with Jersey 2.26 which introduced a few breaking changes:https://jersey.github.io/documentation/latest/user-guide.html#mig-2.26-injection-manager See:94aee46
- Is it possible to use slf4j instead of writing to stderr, directly?
- What's the license of the code? Apache 2.0?
| protected WrappedOutput onRequestFailure(Exception e, | ||
| WrappedInput wrappedInput, | ||
| @Nullable JRestlessContainerRequest jRestlessContainerRequest) { | ||
| System.err.println("request failed" + e.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can this be logged via slf4j?
Thanks for your quick attention! I'll get an update up today or tomorrow. |
Some breaking changes in this version of Jersey. Also sends a System.err.println via slf4j
Uh oh!
There was an error while loading.Please reload this page.
We would like to use JRestless to support running JAX-RS apps on Fn Projects
See Fn Project at: http//fnproject.io
See blog at:http://mjg123.github.io/2017/11/08/Jax-RS-on-Fn.html
See example project at:https://github.com/fnproject/fn-jrestless-example